rocketry icon indicating copy to clipboard operation
rocketry copied to clipboard

Published 20 hours ago • verified publisher icon Miksus

Pylint if/elif/else, returns and isinstance comparisons

Open marksmayo opened this issue 2 years ago • 2 comments

Some more pylint stuff, cleaning up unnecessarily complex if/elif/else branches, and overly complex boolean / instance comparisons. Hope it helps. I'm unsure how to trigger the code coverage you did last time.

marksmayo avatar Sep 27 '22 06:09 marksmayo

Sorry been a bit busy. I'll check this next weekend at the latest.

Thanks again for cleaning the project! This is well appreciated.

Miksus avatar Sep 28 '22 18:09 Miksus

No hurry or worries, I'm learning a lot by working through these, and hopefully they're somewhat useful.

marksmayo avatar Sep 29 '22 00:09 marksmayo

Sorry for taking eternity with this, got distracted with learning about event-driven design (in order to make Rocketry to support its patterns).

I'll try to merge this today evening.

Miksus avatar Oct 11 '22 06:10 Miksus

Thanks again for the PR! Looks indeed good and especially the tests previously had some really odd patterns.

Miksus avatar Oct 11 '22 18:10 Miksus