Mikael Koli

Results 56 comments of Mikael Koli

Thanks for the effort! These sorts of PRs are very welcome as I'm not proficient with Django but it is quite popular to attach Django to Rocketry. I'll see if...

Ye, sorry. It seems I didn't have time and I need to prioritize doing some accounting in my free time but perhaps on the weekend, I could have time again.

Hmm, oh ye. Pass argument "--no-build" with the pytest call. Does that make it to go successfully? If not, I think you can ignore that 👍 I basically made that...

Ye, you can ignore it 👍 I'm thinking of removing that test altogether, or at least remove the command-line argument. The reason for it was a sanity check the version...

Hmm, ye. I think there is some room to improve the command task. Furthermore, the CommandTask does not support asyncio even though it could (there are subprocess functionalities in asyncio)....

Thanks for investing the time to fix this! I respect the time you invested. Mind you if I add a simple test to this PR for the task removal using...

Do you mean that whether you could launch Rocketry without creating the loop (without sync method ``app.run()``)? There is the ``app.serve()`` which is an async function. This is basically the...

Thanks for reporting this! The method does not make much sense: ```python class Session(RedBase): ... def remove_task(self, task: Union['Task', str]): if isinstance(task, str): task = self[task] self.session.tasks.remove(task) ``` We are...

@rohansh-tty, ye, go ahead! I think there was a PR but it had a bit more (tests failed due to that) I suppose it got inactive. What you have there...

Could you link the part of the docs you are looking at? I'm actually just finalizing quite a major update on the docs (rewrote the tutorials, added new parts to...