git-notify-extension icon indicating copy to clipboard operation
git-notify-extension copied to clipboard

MRs from Archived Projects are included in lists

Open tcoffin opened this issue 3 years ago • 2 comments

I have two open MRs on a project. That project was then Archived while the MRs were still open. Those MRs continue to appear in the To Review and Under Review lists for the Extension. The list of personal MRs within the Gitlab interface does not show the MRs from the archived project.

Browser: Firefox Extension Version: 1.5.1

Reproduction steps:

  • Start with a project in the regular state
  • Open an MR for that project
  • Archive the project

tcoffin avatar Jun 09 '22 13:06 tcoffin

Thanks for reporting, I'll have a look :+1:

Mikescops avatar Jun 09 '22 13:06 Mikescops

As of today, it seems that the GitLab API does not provide a way to filter archived MRs. https://docs.gitlab.com/ee/api/merge_requests.html#list-group-merge-requests

Better close MRs in the archived project then... sadly

Mikescops avatar Jun 10 '22 11:06 Mikescops

@Mikescops As per the link you send above there is now a non_archived parameter to filter out MRs from archived projects it set to true.

bastienGranger avatar Nov 05 '22 17:11 bastienGranger

Indeed as stated in the documentation :

non_archived : Returns merge requests from non archived projects only. Default is true.

I'll close the issue but @tcoffin feel free to reopen if this is still an issue on your side, maybe there is something more.

Mikescops avatar Jan 09 '23 22:01 Mikescops