git-notify-extension
git-notify-extension copied to clipboard
Mikescops
WIP: Implement comment notifications
@Mikescops anything I can do to help move this forward? I would love to see this extension support notifications.
@vinnymac well, I have let down this feature for now.
I think we need to find an architecture of how it could work with the limitation of the API. At the beginning, I was thinking of comparing 2 consecutive requests to the API but it's not that easy. I'll think about it again soon. If you have ideas let me know.
@vinnymac well, I have let down this feature for now.
I think we need to find an architecture of how it could work with the limitation of the API. At the beginning, I was thinking of comparing 2 consecutive requests to the API but it's not that easy. I'll think about it again soon. If you have ideas let me know.
Perhaps I am missing some knowledge about how this works, but reading over the code: wouldn’t it be possible for us to pull the last response out of storage, comparing it to the latest api response, and send notifications based on what is new or updated?
Then we would update the local store with the latest api responses, and wait for the next poll, and so on.
If this wouldn’t work, even rudimental-y I wonder what is preventing it. I may spend some time investigating myself as well.
Yeah right, that's the plan, comparing is just not easy between what exists, what doesn't anymore, and what changed. I would have preferred an event-based API but managing webhooks from the extension is not possible.
@Mikescops this might not support all of the desired features, but what if instead we request (and store) the users events
https://docs.gitlab.com/ee/api/events.html
Filter the api response by only events that haven’t been seen before. Then send a notification to the user for each new event.
This would avoid having to diff too many types of API requests. And make the notifications very specific to changes that actually occurred.