The Row with the Check now button is showing doubled

[FloloKrypton]

GitHub supports Markdown: https://guides.github.com/features/mastering-markdown/ Multi-line code blocks either with three back ticks, or four space indent.

Expected Behavior

The row should not duplicate

Current Behavior

The row is duplicating

Possible Solution

I dont know. Thats why i am here.

Steps to Reproduce (for bugs)

I can`t reproduce it. For me it happens every time Grafana refreshs.

Your Environment

• Icinga Web 2 Grafana version (System - About): 1.3.5
• Icinga Web 2 version and modules (System - About): 2.7.3 Director: Master doc: 2.7.3 incubator: 0.5.0 ipl: v0.4.0 monitoring 2.7.3 reactbundle 0.7.0
• Version used (icinga2 --version):2.11.2-1
• Operating System and version: Debian 10
• Enabled features (icinga2 feature list): Disabled features: compatlog debuglog elasticsearch gelf graphite livestatus opentsdb perfdata syslog Enabled features: api checker command ido-mysql influxdb mainlog notification statusdata
• Config validation (icinga2 daemon -C): [2019-11-22 00:56:11 +0100] information/cli: Icinga application loader (version: r2.11.2-1) [2019-11-22 00:56:11 +0100] information/cli: Loading configuration file(s). [2019-11-22 00:56:11 +0100] information/ConfigItem: Committing config item(s). [2019-11-22 00:56:11 +0100] information/ApiListener: My API identity: backupserver.krmail.dev [2019-11-22 00:56:11 +0100] information/ConfigItem: Instantiated 1 InfluxdbWriter. [2019-11-22 00:56:11 +0100] information/ConfigItem: Instantiated 1 FileLogger. [2019-11-22 00:56:11 +0100] information/ConfigItem: Instantiated 1 NotificationComponent. [2019-11-22 00:56:11 +0100] information/ConfigItem: Instantiated 1 IcingaApplication. [2019-11-22 00:56:11 +0100] information/ConfigItem: Instantiated 3 HostGroups. [2019-11-22 00:56:11 +0100] information/ConfigItem: Instantiated 11 Hosts. [2019-11-22 00:56:11 +0100] information/ConfigItem: Instantiated 1 CheckerComponent. [2019-11-22 00:56:11 +0100] information/ConfigItem: Instantiated 5 Zones. [2019-11-22 00:56:11 +0100] information/ConfigItem: Instantiated 1 StatusDataWriter. [2019-11-22 00:56:11 +0100] information/ConfigItem: Instantiated 4 Endpoints. [2019-11-22 00:56:11 +0100] information/ConfigItem: Instantiated 1 ExternalCommandListener. [2019-11-22 00:56:11 +0100] information/ConfigItem: Instantiated 3 ApiUsers. [2019-11-22 00:56:11 +0100] information/ConfigItem: Instantiated 1 ApiListener. [2019-11-22 00:56:11 +0100] information/ConfigItem: Instantiated 1 IdoMysqlConnection. [2019-11-22 00:56:11 +0100] information/ConfigItem: Instantiated 236 CheckCommands. [2019-11-22 00:56:11 +0100] information/ConfigItem: Instantiated 1 User. [2019-11-22 00:56:11 +0100] information/ConfigItem: Instantiated 67 Services. [2019-11-22 00:56:11 +0100] information/ConfigItem: Instantiated 6 ServiceGroups. [2019-11-22 00:56:11 +0100] information/ScriptGlobal: Dumping variables to file '/var/cache/icinga2/icinga2.vars' [2019-11-22 00:56:11 +0100] information/cli: Finished validating the configuration file(s).

[Mikesch-mp]

I know that issue, but the code is a contribute. I asked them to help/fix, but i got no answer until now. So in the next release i will kick out the code for iframe refresh.

[Mikesch-mp]

Since the contributer does not answer, i will kick this code out.

[raptorblue]

Hi,

I ran into the same issue with icingaweb 2.7.3 and Grafana Module 1.3.6 (and master). Removing the code ( $this->provideJsFile('behavior/iframe.js') in configuration.php) fixes the issue with the duplicate quick-actions.

However then the Grafana iframe is reloaded on every refresh which means the graph disappears for second or so. Also the selection of the time range or the data row is back to default (well, reload even). So just removing this code is not the best option from my point of view.

But now the good news: It seems to work with icingaweb 2.8.0-rc1

Also the change made in public/js/behavior/iframe.js in commit 659f147947aabdbc9ca67b8513029f93e1b8baaa is not necessary (any more) as far as I can tell.

@Mikesch-mp Please keep this feature working. I see it as a huge boost of usability if the graphs are steady and selections (by mouse) remain in place.

Thanks a lot!

[jgkirschbaum]

@Mikesch-mp are there any plans for disabling the autorefresh behavior of granfana graphs in an iframe?

[Mikesch-mp]

@jgkirschbaum as soon Icinga make it configurable, which is an open issue since years. From module side i cant disable it or change it.

[jgkirschbaum]

Short feedback from my side to this issue:

Installed Software

Software	Version
icingaweb2	2.8.1
icingaweb2-module-grafana	1.3.6
php	7.1.30
grafana	7.0.5

• Grafana is configured with auth.anonymous enabled and TLS as icingaweb2 is.
• icingaweb2-module-grafana is installed as is, i.e. $this->provideJsFile('behavior/iframe.js'); in configuration.php is not commented out as mentioned by @raptorblue
• The bug with the duplicate action row as in the first post of this issue by @FloloKrypton disappeared with icingaweb2 version 2.8.1
• Autoreload of the embedded iframe does not occur.

So for me now everything works like a charm.

@Mikesch-mp Please don't revert change made in public/js/behavior/iframe.js in commit https://github.com/Mikesch-mp/icingaweb2-module-grafana/commit/659f147947aabdbc9ca67b8513029f93e1b8baaa

[aledr]

Seems working fine for me on Icinga Web 2 Version 2.10.1.