api-client icon indicating copy to clipboard operation
api-client copied to clipboard

Don't swallow errors

Open dogmatic69 opened this issue 2 years ago • 0 comments

Just spent a good few hours debugging an issue in a request which was reported as:

Error when contacting https://....

but was actually some AsyncIO error due to blocking calls within a async loop.

This should only catch underlying HTTP errors

https://github.com/MikeWooster/api-client/blob/522700a80405b9523d0613ff96162241a2abd72e/apiclient/request_strategies.py#L99

dogmatic69 avatar Jan 22 '22 23:01 dogmatic69