Michal Kuzela
Michal Kuzela
@Skrypt Ok, I was out for a while, but I have merged it now and tested - still working ok.
@Skrypt Just a question - does "Needs triage" mean anything for me, or is it just waiting for some group review? I am not very familliar with how this triage...
@Skrypt Implemented suggested changes, Merged main into this branch but **I still need to check tomorrow if it did not break anything** - kinda lot changes
@Skrypt Tested, fixed codemirror. It is working fine again with the new changes. Maybe it should be reviewed by @MikeAlhayek, because there were many a lot of conflicts with https://github.com/OrchardCMS/OrchardCore/pull/12103
Is it possible, that this will make it to version 1.5?
@sebastienros Not sure what you mean, because Autoroute paths generation also pass culture aspect to liquid templates (and imho it can't be generated without manually getting culture aspect). It can...
@sebastienros So you mean, that new ContentPickerAspect is not needed? That is ok and I can change it, but feels like step-back to state before this commit https://github.com/OrchardCMS/OrchardCore/pull/8280/commits/72661068bc33f4788ed78d478b54f91bc543beb6#diff-c12e6f2791029f70fa686c607691139163bfd007933317dfb86d22c3122e671f Where @deanmarcussen...
@sebastienros What is your decision, should I revert it or no? I would like to finish this as it is open for 1 year already :)
@MikeAlhayek Sure, I pushed merge into my branch. Is there possibility, that it will be merged any time soon? It starts to be little uncomfortable using content picker with growing...
I see that release 1.6 is already merged, but this PR did not make it through.. will it ever be merged?