Mike J Innes

Results 334 comments of Mike J Innes

I generally agree that anything user-facing should not have unicode in it (and there are a few places we need to fix this). At the same time fields like this...

Right, no one should be forced to use unicode to build a model with Flux -- which sounds like it's the case for you. We can change the fieldnames but...

If you want to start with batchnorm, that's in `src/layers/normalise.jl`.

This is great. We are hoping to turn our model-zoo models into notebooks and eventually online tutorials by adding comments like this, so it might be good to add some...

This looks generally good but could use a bit more instructions/walkthrough – otherwise I'm not sure how to start playing around with it. Some simple steps to getting it running...

Ok, I think I finally have this figured out. The trick is that you need the gradient of the *module* as if it were any other struct. Then global variables...

In what sense? This does make it ridiculously easy to extend layer behaviour, e.g. ```julia l1 = Dense(10, 5) l2 = x -> relu.(l1(x)) ``` and `l2` can now be...

Yeah, we are of course limited by what Julia can express here, so still can't do Python-style inheritance exactly. But it'd be easy to do this via composition (which can...

I think the important point from an AD perspective is that if you can write it down, it will work :) Feel free to open a new issue to discuss...

Yeah, both ways of writing this are equivalent (and identical in terms of performance etc). You can implement `grad` as ```julia grad(f) = x -> gradient(f, x)[1] ``` And implement...