Michael Dombrowski

IP detector will update the IP address whenever it changes, this can happen frequently on mobile connections. Check the greengrass log file to see what is going on; any update...

Beyond being slow, this also allocates ~10MB based on a test with async-profiler. If none of this data is ever retrieved, then this is very wasteful, creating a spike of...

How would you expect this to work? What would the generated code look like? The property `id` would need to be either a string or a boolean (or in theory,...

I'm publishing every single metric which is exposed via RRD. Sounds like those metrics may not be exposed via the "/metrics" API in Xen. I would accept a pull request...

Yes, those are not RRD metrics, but there's no reason why they could not be included here.

That code is for building the metric name for the sr metrics which are exposed via RRD which are ``` xen_host_sr_cache_hits xen_host_sr_cache_misses xen_host_sr_cache_size ```

You could extend this code with more metrics by adding here: https://github.com/MikeDombo/xen-exporter/blob/master/xen-exporter.py#L221 call a method which will gather the SR metrics you like, and then add them to the `output`...

I updated the script to pull these stats with some changes from what you wrote: https://github.com/MikeDombo/xen-exporter/commit/e2864931203bf7632428ea0790997abc0df58256. Example metrics: ``` xen_sr_physical_size{sr_uuid="cc47bb42-9256-b00c-ae38-c51612fa16b1", sr="Local storage", type="ext", content_type="user"} 1940612173824 xen_sr_physical_utilization{sr_uuid="cc47bb42-9256-b00c-ae38-c51612fa16b1", sr="Local storage", type="ext", content_type="user"}...


Let me know when this is ready for review by marking the PR as "ready for review".