Mike Bishop

Results 236 comments of Mike Bishop

Consumption/generation in TWCMaster is only updated while a Green policy is active. So if the car is charging because there's solar available, they'll be accurate. If the car is charging...

Careful with that.... IIRC, that background task actually sets the `charge_amps` (you'll note that Track Green Energy doesn't supply a `charge_amps` value). So just adding the task to the policy...

I suspect if we want green energy polling all the time, we either need to split `checkGreenEnergy` up into two pieces; one that fetches the data and one that applies...

Because when you're doing a green policy, the charge limit is set based on the generation/consumption numbers.

Actually, no -- I was. This is `charge_amps`, not `charge_limit` that's being overridden.

I think another way you could scope it, since we've already taken the step of keeping home/not-home status for each car, is to send the stop command to all cars...

Unless you're envisioning a mode where one charger is allowed to proceed and the other isn't (which there is a use for -- two cars that want to charge, with...

No, because the indicator that something is a green policy is the presence of that background task. def policyIsGreen(self): if self.getPolicyByName(self.active_policy): return ( self.getPolicyByName(self.active_policy).get("background_task", "") == "checkGreenEnergy" ) return 0...

I'd think at that point it makes more sense to just always run the background task, maybe with an option to turn it off for non-green policies if you're API-limited.

I honestly question whether that setting provides value, given that we use location for charge limits without a gate. We should either have a "use location" toggle that's respected globally...