D2ArmorPicker icon indicating copy to clipboard operation
D2ArmorPicker copied to clipboard

Optimize item parsing when a mod with a bonus or penalty is equipped

Open Mijago opened this issue 3 years ago • 2 comments

Currently, when an item is parsed, D2AP takes the stats taken from the API and adds/removes the stats given by any equipped Mods. If the item is masterworked, it then reduces all stats by 2.

Problem: The API caps all stats between 0 and 42. If an item has a base stat of 4 strength and you equip Protective Light, it then has -6 strength. The Api only returns 0, which results in the tool thinking it has 8 strength (0+10-2).

Fix: currently unknown. DIM had this bug for a long time but fixed it a few weeks ago, so investigating this would probably help. Any help appreciated.

Mijago avatar Aug 14 '21 06:08 Mijago

Does this bug also cover the issue of armor pieces with too high of stats not showing up as potential matches in the tool?

SpencerCarstens avatar Aug 14 '21 23:08 SpencerCarstens

Does this bug also cover the issue of armor pieces with too high of stats not showing up as potential matches in the tool?

Yes.

Mijago avatar Aug 15 '21 07:08 Mijago

This issue has been fixed a long time ago.

Mijago avatar Apr 24 '23 11:04 Mijago