ember-cli-bundle-loader icon indicating copy to clipboard operation
ember-cli-bundle-loader copied to clipboard

Published 20 hours ago • verified publisher icon MiguelMadero

Avoid errors if handler._populateQPMeta is missing

Open rwjblue opened this issue 8 years ago • 2 comments

Upstream changes are removing the _populateQPMeta method on Ember.Route instances (in order to prevent the corresponding controller from being eagerly looked up).

This preserves the same semantics, but avoids invocation of handler._populageQPMeta if it is not present.

Related PRs:

  • https://github.com/emberjs/ember.js/pull/14980
  • https://github.com/ember-engines/ember-engines/pull/353

rwjblue avatar Mar 03 '17 16:03 rwjblue

Looks like the 1.13 tests are failing, but I'm not very familiar with the test setup. Can someone take a look at the failure and provide guidance? I'm happy to fix...

rwjblue avatar Mar 05 '17 14:03 rwjblue

Wow, for someone reason I missed this almost a year ago.

Thanks for opening this PR. I'll have a look.

MiguelMadero avatar Jan 27 '18 21:01 MiguelMadero