OpenComputers icon indicating copy to clipboard operation
OpenComputers copied to clipboard

Published 20 hours ago • verified publisher icon MightyPirates

Wand aspect list display added, IAspectContainer display fixed

Open repo-alt opened this issue 3 years ago • 3 comments

repo-alt avatar Jun 16 '22 07:06 repo-alt 

> Task :sourceMainScala
Error:  /home/runner/work/OpenComputers/OpenComputers/build/sources/scala/li/cil/oc/integration/thaumcraft/ConverterAspectItem.scala:8: object common is not a member of package thaumcraft
> Task :compileScala
Error:  /home/runner/work/OpenComputers/OpenComputers/build/sources/scala/li/cil/oc/integration/thaumcraft/ConverterAspectItem.scala:20: not found: type ItemWandCasting
Error:  /home/runner/work/OpenComputers/OpenComputers/build/sources/scala/li/cil/oc/integration/thaumcraft/ConverterAspectItem.scala:21: value getAllVis is not a member of net.minecraft.item.Item

Is there a way to implement this without depending on Thaumcraft internals? Even then, the build script would have to be adjusted...

asiekierka avatar Jun 17 '22 21:06 asiekierka

Well, I don't think we may expect another 1.7.10 Thaumcraft release, so it is probably safe to depend on the internal interface. (I have no idea why it is even internal)

repo-alt avatar Jun 21 '22 07:06 repo-alt

(Thaucraft API should probably be deleted from the repository if that PR is accepted, but that is up to you)

repo-alt avatar Jun 21 '22 08:06 repo-alt