sym icon indicating copy to clipboard operation
sym copied to clipboard

Fix backwards navigation

Open keipes opened this issue 3 years ago • 1 comments

~~Update search params in window location directly, instead of pushing state and forcing a refresh. This makes forward/backward behavior work for me.~~

2nd commit:

Started looking at getting right-click open in new tab working after the initial commit. Figured it would be easier to just change the divs to anchor tags. After doing that I noticed that the game specific links are setup in two places (the main page content, and the dropdown menu). So to reduce the number of places that information is repeated I pulled all the game specific data into two objects (GAMES, PAGE_TYPES), and added functions to create the DOM elements for both the dropdown menu and main page links.

  • sym-game-datatype links are now anchor tags
  • Game specific links are now specified once in javascript rather than once in HTML (dropdown menu) and again in JS (main page links).
  • Added a case statement for game=sym, page=home.
    • Before this change right clicking the site banner and opening in a new tab would result in a mostly blank page.

I'm just interested in getting forward/backward navigation and right-click link functionality working, so if the reformatting is too extreme I'm happy to make a new commit with fewer changes.

keipes avatar Sep 12 '22 00:09 keipes

@robenter Would you have time to take a look at this as navigation is your handywork?

Miffyli avatar Sep 12 '22 17:09 Miffyli