structurizr-python icon indicating copy to clipboard operation
structurizr-python copied to clipboard

feat: add missing automatic layout params

Open WLun001 opened this issue 3 years ago • 9 comments

  • [x] fix #87
  • [ ] description of feature/fix
  • [ ] tests added/passed
  • [x] add an entry to the next release

New to python, please help me to review @Midnighter

WLun001 avatar Jan 11 '22 06:01 WLun001

Actually, I took a look at the Java and the API definition and these two attributes are not part of the AutomaticLayout, it seems.

Midnighter avatar Jan 24 '22 09:01 Midnighter

but i able to get it from the UI by inspecting the network tab

https://graphviz.structurizr.com/?view=id&resizePaper=true&rankDirection=TB&rankSeparation=300&nodeSeparation=300&margin=400

WLun001 avatar Jan 24 '22 09:01 WLun001

@simonbrowndotje can you comment on what the intention for resizePaper and margin is? From where should that be set?

Midnighter avatar Jan 24 '22 10:01 Midnighter

I found on the java SDK and the docs

WLun001 avatar Jan 24 '22 10:01 WLun001

Those are only currently used when manually initiating auto-layout from the Structurizr UI.

Screenshot 2022-01-24 at 11 26 03

simonbrowndotje avatar Jan 24 '22 10:01 simonbrowndotje

@WLun001 I guess this first needs to be a feature request on the Structurizr API then before we can make changes here on the Python SDK.

Midnighter avatar Jan 24 '22 10:01 Midnighter

I found on the java SDK and the docs

@Midnighter how about this? already on the Java SDK

WLun001 avatar Jan 24 '22 10:01 WLun001

The Python package only interacts with the web facing API. So we can only support what is possible through this API.

Midnighter avatar Jan 24 '22 12:01 Midnighter

@Midnighter I see. So we have to wait the web facing APIs to update

WLun001 avatar Jan 26 '22 01:01 WLun001

I will close this as part of a clean up.

Midnighter avatar Jan 21 '23 09:01 Midnighter