RPi-Jukebox-RFID
RPi-Jukebox-RFID copied to clipboard
feat: Add resume position tracking for all play types
The tracking is active by default, but the resuming has to be enabled explicitly, either by setting
playermpd.play_position_tracking.resume_by_default: true
or by calling the play_* functions with the new resume=True kwarg.
Related: #1946
Reasons for draft status / checklist before merging:
- [ ] #2330
- [ ] Removal of existing partial resume support
- [ ] Final round of testing
I've been using most of the code on my Phoniebox without problems. The code has seen some adjustments by now though, so it hasn't been tested as-is. Other than that, it's ready for review. I will do a final round of testing when the reviews are done.
Previous review by @pabera (most of the actionable items should have been incorporated by now): https://github.com/hoffie/RPi-Jukebox-RFID/commit/c4805cebb848e8aaafd69c43f497b09436e67169
Pull Request Test Coverage Report for Build 8653786800
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 38.336%
Totals | |
---|---|
Change from base Build 8605260930: | 0.0% |
Covered Lines: | 493 |
Relevant Lines: | 1286 |