RPi-Jukebox-RFID icon indicating copy to clipboard operation
RPi-Jukebox-RFID copied to clipboard

Published 20 hours ago • verified publisher icon MiczFlor

Multi Player Support

Open Groovylein opened this issue 1 year ago • 5 comments

Ground work for multiple players.

Basis to solve Spotify issues or other streaming services on future3, see #1815 and #2116

Groovylein avatar Dec 15 '23 21:12 Groovylein

Great work! I was thinking for a while abstracting the player would be great and thus am excited to see these changes. Personally I am thinking to implement a player supporting the subsonic api used by various open source music managers such as Navidrome in the future. This would greatly facilitate this.

Thank you. It is still under construction and I am not that experienced in python object oriented programming. I am happy about review/improvements of my code.

The idea is to have modular players, but currently the content collector and representation in the webapp is missing 🫣

Groovylein avatar Dec 29 '23 15:12 Groovylein

Pull Request Test Coverage Report for Build 8924248257

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 38.235%
Totals Coverage Status
Change from base Build 8775015840: 0.0%
Covered Lines: 494
Relevant Lines: 1292
💛 - Coveralls

coveralls avatar Jan 08 '24 14:01 coveralls

For reference this PR is the base for #2116

s-martin avatar Feb 01 '24 13:02 s-martin