Demos-old icon indicating copy to clipboard operation
Demos-old copied to clipboard

Check video.error for null on MSE/EME demo

Open hsivonen opened this issue 9 years ago • 4 comments

Steps to reproduce:

  1. Navigate to https://developer.microsoft.com/en-us/microsoft-edge/testdrive/demos/eme/ in Firefox.
  2. In the list of videos on the left, click any video that's not the currently-selected one.

Actual results: A message "TypeError: video.error is null" is logged.

Expected results: No error.

Additional info: The error location is line 729 in demo.js, which reads:

if (video.error.msExtendedCode) {

That line should null-check video.error before trying to check the msExtendedCode property on it.

hsivonen avatar Apr 15 '16 07:04 hsivonen

CC @mohmoto

hsivonen avatar Apr 15 '16 07:04 hsivonen

CC @molant

dstorey avatar Apr 15 '16 21:04 dstorey

@mohmoto what do you want to do with this? As they say in https://github.com/webcompat/web-bugs/issues/1855 Firefox doesn't support WebM content in EME yet.

molant avatar May 05 '16 17:05 molant

I'll fix this. It's pretty low pri though as it's in an error path.

mohmoto avatar May 06 '16 15:05 mohmoto