windows-powershell-docs icon indicating copy to clipboard operation
windows-powershell-docs copied to clipboard

SmbShare module new compression parameters

Open robinharwood opened this issue 3 years ago • 3 comments

robinharwood avatar Sep 15 '22 16:09 robinharwood

Docs Build status updates of commit d01d079:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/smbshare/New-SmbShare.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Reset-SmbClientConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Reset-SmbServerConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Set-SmbClientConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Set-SmbServerConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

opbld31 avatar Sep 15 '22 16:09 opbld31

Hi @nedpyle - I can't assigned you for review in this repo but hopefully tagging you here will help. This is the PR to update the SMB compression parameters. Please let me know if you have a good example to add and let me know your thoughts on the parameter text. Of course, I'm happy for us to expand these as discussed.

Thanks, Robin

robinharwood avatar Sep 21 '22 16:09 robinharwood

Docs Build status updates of commit fe9526d:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/smbshare/New-SmbShare.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Reset-SmbClientConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Reset-SmbServerConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Set-SmbClientConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Set-SmbServerConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

opbld33 avatar Sep 22 '22 14:09 opbld33

Learn Build status updates of commit c5e45eb:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/smbshare/New-SmbShare.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Reset-SmbClientConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Reset-SmbServerConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Set-SmbClientConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Set-SmbServerConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

opbld33 avatar Oct 20 '22 14:10 opbld33

Learn Build status updates of commit c5e45eb:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/smbshare/New-SmbShare.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Reset-SmbClientConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Reset-SmbServerConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Set-SmbClientConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Set-SmbServerConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

opbld31 avatar Oct 20 '22 14:10 opbld31

Learn Build status updates of commit a7f90ec:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/smbshare/New-SmbShare.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Reset-SmbClientConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Reset-SmbServerConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Set-SmbClientConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Set-SmbServerConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

opbld32 avatar Oct 20 '22 14:10 opbld32

Learn Build status updates of commit 62153eb:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/smbshare/New-SmbShare.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Reset-SmbClientConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Reset-SmbServerConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Set-SmbClientConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Set-SmbServerConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

opbld32 avatar Oct 21 '22 11:10 opbld32

Hi @michaeltlombardi / @sdwheeler,

I believe this PR is release ready if you would be kind enough to review and if appropriate sign-off/merge 😊

The main update was to add in new compression parameters, I have also addressed some quality issues at the same time.

Please let me know if you have any questions or if I need to apply any other updates.

Thanks Robin

robinharwood avatar Oct 21 '22 12:10 robinharwood

Learn Build status updates of commit f1fb3ad:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/smbshare/New-SmbShare.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Reset-SmbClientConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Reset-SmbServerConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Set-SmbClientConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Set-SmbServerConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

opbld33 avatar Nov 07 '22 17:11 opbld33

Learn Build status updates of commit 2e512d6:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/smbshare/New-SmbShare.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Reset-SmbClientConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Reset-SmbServerConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Set-SmbClientConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Set-SmbServerConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

opbld30 avatar Nov 08 '22 15:11 opbld30

Learn Build status updates of commit 7384f18:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/smbshare/New-SmbShare.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Reset-SmbClientConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Reset-SmbServerConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Set-SmbClientConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Set-SmbServerConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

opbld30 avatar Nov 08 '22 15:11 opbld30

Thanks @michaeltlombardi and @JohanFreelancer9 - Updates applied, I believe this is now ready to merge. #sign-off

robinharwood avatar Nov 09 '22 11:11 robinharwood

Learn Build status updates of commit 5929e78:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/smbshare/New-SmbShare.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Reset-SmbClientConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Reset-SmbServerConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Set-SmbClientConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Set-SmbServerConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

opbld32 avatar Nov 10 '22 10:11 opbld32

Learn Build status updates of commit 2037748:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docset/winserver2022-ps/smbshare/New-SmbShare.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Reset-SmbClientConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Reset-SmbServerConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Set-SmbClientConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)
docset/winserver2022-ps/smbshare/Set-SmbServerConfiguration.md :white_check_mark:Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

opbld30 avatar Nov 10 '22 11:11 opbld30

Hi @michaeltlombardi - I think all comments are now addressed. Thanks, Robin

robinharwood avatar Nov 10 '22 12:11 robinharwood

Thanks for approving @michaeltlombardi - are you able to do the #sign-off and merge? I don't have the permissions for this repo.

robinharwood avatar Nov 10 '22 16:11 robinharwood

@robinharwood sorry, thought I hit the button before closing the tab! 😣

michaeltlombardi avatar Nov 10 '22 17:11 michaeltlombardi