edge-developer icon indicating copy to clipboard operation
edge-developer copied to clipboard

Remove MV2 code from "Create an extension tutorial, part 1"

Open bhuvanapriyap opened this issue 1 year ago • 1 comments

This PR is finished & on-hold waiting for Extensions repo Part 1 to be updated from MV2 to MV3, per PR: https://github.com/microsoft/MicrosoftEdge-Extensions/pull/202 manifest.json: https://github.com/microsoft/MicrosoftEdge-Extensions/blob/main/Extension%20samples/extension-getting-started-part1/part1/manifest.json -- "manifest_version": 2, When that line becomes "manifest_version": 3,, this PR can be merged.

Rendered articles for review:

  • Tutorial part 1: Create a simple extension (part1-simple-extension.md)
    • https://review.learn.microsoft.com/microsoft-edge/extensions-chromium/getting-started/part1-simple-extension?branch=pr-en-us-3277
    • Before/Live
    • Changed title from "Create an extension tutorial, part 1".
    • Removed Manifest v2 code.
    • Removed tabset tagging.
    • Removed "The source code has been updated from Manifest V2 to Manifest V3."
    • Reformatted plain sentences as numbered steps.
    • Added how to clone the Extensions Samples repo.
    • Clarified how to obtain the image files.
    • Clarified intro to describe part 1 demo's UX.
    • In manifest code, differentiated Name and Description of the Part 1 demo vs Part 2 demo.
    • Re-created screenshots and updated them, using a Microsoft-owned site, and added screenshots.
      • Added screenshot of the simple extension running.
  • Tutorial part 2: Add JavaScript to the extension (part2-content-scripts.md)
    • https://review.learn.microsoft.com/microsoft-edge/extensions-chromium/getting-started/part2-content-scripts?branch=pr-en-us-3277
    • Before/Live
    • Changed title from "Create an extension tutorial, part 2".
    • Removed note about using MV2 when creating a new extension.
    • In heading, changed "pop-up.html" (wrong filename) to "the webpage".
    • Clarified intro to describe part 2 demo's UX.
    • Added filename above each listing, & whether it's a portion or the complete listing.
    • In some steps, linked to "Sideload an extension to install and test it locally", to update & run the expanded sample.
    • Removed stray "8." step.
    • In manifest code, differentiated Name and Description of the Part 1 demo vs Part 2 demo.
    • Re-created screenshots and updated them, using a Microsoft-owned site, and added screenshots.
  • Sideload an extension to install and test it locally (extension-sideloading.md)
    • https://review.learn.microsoft.com/microsoft-edge/extensions-chromium/getting-started/extension-sideloading?branch=pr-en-us-3277
    • Before/Live
    • Integrated with the tutorial articles, for better flow, comprehension, & maintainability.
      • Explicitly specified the "picture of the day" tutorial's extension, as a specific example to follow the steps end-to-end.
    • Changed title from "Sideload an extension", to state the task/ objective.
      • Rewrote intro to clarify the scenario, task, strategy, & objective.
    • Added the main h2 heading "Locally installing and running an extension".
      • Added how to run the installed extension.
      • Clarified the other h2 headings to clarify each task.
    • Re-created screenshots and updated them, using a Microsoft-owned site, and added screenshots.
  • Microsoft Edge documentation (hub page for Edge docsets) (~/index.yml)
    • https://review.learn.microsoft.com/microsoft-edge/?branch=pr-en-us-3277
    • Before/Live
    • Updated the redirected url for macOS.
    • Changed "Port a Chromium extension to Microsoft Edge" to "Port a Chrome extension to Microsoft Edge".
  • Microsoft Edge Developer documentation (landing page for entire docset) (/developer/index.yml)
    • https://review.learn.microsoft.com/microsoft-edge/developer/?branch=pr-en-us-3277
    • Before/Live
    • Changed "Port a Chromium extension to Microsoft Edge" to "Port a Chrome extension to Microsoft Edge".
  • Microsoft Edge extensions documentation (landing page for Extensions) (/extensions/landing/index.yml)
    • https://review.learn.microsoft.com/microsoft-edge/extensions-chromium/landing/?branch=pr-en-us-3277
    • Before/Live
    • Lowercased "Extensions" in title of landing page.
    • Changed "Sideload an extension" to "Sideload an extension to install and test it locally".
  • TOC (toc.yml)
    • https://review.learn.microsoft.com/microsoft-edge/extensions-chromium/landing/?branch=pr-en-us-3277
    • Before/Live
    • Changed "Sideload an extension" to "Sideload an extension to install and test it locally".

AB#54090321

bhuvanapriyap avatar Sep 24 '24 10:09 bhuvanapriyap

Learn Build status updates of commit f63f101:

:white_check_mark: Validation status: passed

File Status Preview URL Details
microsoft-edge/developer/index.yml :white_check_mark:Succeeded View
microsoft-edge/devtools-guide-chromium/sources/index.md :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/developer-guide/sidebar.md :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/extension-running.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/extensions-icon.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/extensions-popup-no-extensions.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/extensions-popup.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/load-unpacked-icon.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/part1-developermode-toggle.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/part1-installed-extension.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/part1-threedots.png :white_check_mark:Succeeded n/a (file deleted or renamed)
microsoft-edge/extensions-chromium/getting-started/extension-sideloading.md :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/index.md :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension-images/extension-running.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/part2-content-scripts-images/extensions-icon.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/part2-content-scripts-images/open-the-extension.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/part2-content-scripts-images/part2-popupdialog.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/part2-content-scripts-images/part2-showingimage.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/part2-content-scripts.md :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/index.md :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/landing/index.yml :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/publish/contact-extensions-team.md :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/publish/reply-user-reviews.md :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/whats-new/released-features.md :white_check_mark:Succeeded View

This comment lists only the first 25 files in the pull request. For more details, please refer to the build report.

For any questions, please:

Learn Build status updates of commit 8588c8b:

:white_check_mark: Validation status: passed

File Status Preview URL Details
microsoft-edge/developer/index.yml :white_check_mark:Succeeded View
microsoft-edge/devtools-guide-chromium/sources/index.md :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/developer-guide/sidebar.md :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/extension-running.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/extensions-icon.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/extensions-popup-no-extensions.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/extensions-popup.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/load-unpacked-icon.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/part1-developermode-toggle.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/part1-installed-extension.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/extension-sideloading-images/part1-threedots.png :white_check_mark:Succeeded n/a (file deleted or renamed)
microsoft-edge/extensions-chromium/getting-started/extension-sideloading.md :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/index.md :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension-images/extension-running.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/part1-simple-extension.md :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/part2-content-scripts-images/extensions-icon.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/part2-content-scripts-images/open-the-extension.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/part2-content-scripts-images/part2-popupdialog.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/part2-content-scripts-images/part2-showingimage.png :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/getting-started/part2-content-scripts.md :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/index.md :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/landing/index.yml :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/publish/contact-extensions-team.md :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/publish/reply-user-reviews.md :white_check_mark:Succeeded View
microsoft-edge/extensions-chromium/whats-new/released-features.md :white_check_mark:Succeeded View

This comment lists only the first 25 files in the pull request. For more details, please refer to the build report.

For any questions, please: