cpp-docs icon indicating copy to clipboard operation
cpp-docs copied to clipboard

Update arm64-intrinsics.md to include intrin.h mention

Open janisozaur opened this issue 1 year ago • 4 comments

Some intrinsics, such as __prefetch come from intrin.h header file.

janisozaur avatar Apr 25 '24 11:04 janisozaur

@janisozaur : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Apr 25 '24 11:04 prmerger-automator[bot]

Learn Build status updates of commit cd4fa5a:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docs/intrinsics/arm64-intrinsics.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

@sigatrev

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

Court72 avatar Apr 25 '24 14:04 Court72

This change implies that some neon intrinsics are included through intrin.h which is not correct. The intrinsics listed explicitly on that page are the intrinsics that are not neon.

I do agree that we should mention the header to include for those intrinsics, but probably with a note under the ARM64-specific intrinsics listing header, rather than under the Neon header.

sigatrev avatar Apr 25 '24 18:04 sigatrev

Learn Build status updates of commit 45db299:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docs/intrinsics/arm64-intrinsics.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

Learn Build status updates of commit 2733260:

:white_check_mark: Validation status: passed

File Status Preview URL Details
docs/intrinsics/arm64-intrinsics.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

@sigatrev - I updated per your feedback.

TylerMSFT avatar Jun 21 '24 20:06 TylerMSFT

#sign-off

TylerMSFT avatar Jun 21 '24 20:06 TylerMSFT

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @sigatrev

prmerger-automator[bot] avatar Jun 21 '24 20:06 prmerger-automator[bot]

#sign-off

TylerMSFT avatar Jun 21 '24 22:06 TylerMSFT

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @sigatrev

prmerger-automator[bot] avatar Jun 21 '24 22:06 prmerger-automator[bot]

#sign-off

TylerMSFT avatar Jun 21 '24 22:06 TylerMSFT

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @sigatrev

prmerger-automator[bot] avatar Jun 21 '24 22:06 prmerger-automator[bot]

Thanks for getting this merged, hopefully more software gets ported to neon

janisozaur avatar Jun 22 '24 16:06 janisozaur