azure-reference-other icon indicating copy to clipboard operation
azure-reference-other copied to clipboard

Update azurediagnostics.md

Open josecons-msft opened this issue 1 year ago • 6 comments

josecons-msft avatar May 15 '24 10:05 josecons-msft

@josecons-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar May 15 '24 10:05 prmerger-automator[bot]

Learn Build status updates of commit 5a29d43:

:white_check_mark: Validation status: passed

File Status Preview URL Details
azure-monitor-ref/tables/azurediagnostics.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

@EdB-MSFT

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

Court72 avatar May 15 '24 14:05 Court72

Made some modification and it's approved.

yossi-y avatar May 22 '24 15:05 yossi-y

#sign-off

yossi-y avatar May 23 '24 06:05 yossi-y

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @EdB-MSFT

prmerger-automator[bot] avatar May 23 '24 06:05 prmerger-automator[bot]

Made some modification and it's approved.

Hi @yossi-y - I noticed this comment that says you made an update, but I don't see a commit in the PR. I wanted to double-check before merging.

Court72 avatar May 23 '24 14:05 Court72

Not sure what is the right procedure, I thought I need to give the comment and reviewer, or Ed should commit and merge. Let me know if I need to do something.

yossi-y avatar May 26 '24 06:05 yossi-y

@EdB-MSFT

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

Court72 avatar May 28 '24 14:05 Court72

completed in another PR #please-close

EdB-MSFT avatar Jul 21 '24 13:07 EdB-MSFT