azure-docs icon indicating copy to clipboard operation
azure-docs copied to clipboard

ASA-E Spring Cloud Gateway edits

Open candicenonsense opened this issue 2 years ago • 9 comments

candicenonsense avatar Oct 12 '22 21:10 candicenonsense

CLA assistant check
All CLA requirements met.

ghost avatar Oct 12 '22 21:10 ghost

Learn Build status updates of commit 5837234:

:warning: Validation status: warnings

File Status Preview URL Details
articles/spring-apps/how-to-configure-enterprise-spring-cloud-gateway.md :warning:Warning Details
articles/spring-apps/how-to-use-enterprise-spring-cloud-gateway.md :warning:Warning Details

articles/spring-apps/how-to-configure-enterprise-spring-cloud-gateway.md

  • Line 58, Column 4: [Warning: file-not-found - See documentation] Invalid file link: 'media/how-to-configure-enterprise-spring-cloud-gateway/gateway-overview.png'.
  • Line 93, Column 4: [Warning: file-not-found - See documentation] Invalid file link: 'media/how-to-configure-enterprise-spring-cloud-gateway/gateway-configuration.png'.
  • Line 121, Column 4: [Warning: file-not-found - See documentation] Invalid file link: 'media/how-to-configure-enterprise-spring-cloud-gateway/gateway-sso-configuration.png'.

articles/spring-apps/how-to-use-enterprise-spring-cloud-gateway.md

  • Line 130, Column 4: [Warning: file-not-found - See documentation] Invalid file link: 'media/how-to-use-enterprise-spring-cloud-gateway/gateway-overview.png'.
  • Line 178, Column 4: [Warning: file-not-found - See documentation] Invalid file link: 'media/how-to-use-enterprise-spring-cloud-gateway/gateway-route.png'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

opbld33 avatar Oct 12 '22 21:10 opbld33

@candicenonsense : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Oct 12 '22 21:10 prmerger-automator[bot]

@candicenonsense, if this PR is ready for review and merge, please select the "Ready for review" button in the PR. Thanks.

jborsecnik avatar Oct 12 '22 21:10 jborsecnik

(it needs to be moved out of "Draft" mode)

jborsecnik avatar Oct 13 '22 21:10 jborsecnik

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

Jak-MS avatar Oct 14 '22 15:10 Jak-MS

@jborsecnik I will be working with @KarlErickson on this this week and un-draft then, thank you!

candicenonsense avatar Oct 17 '22 14:10 candicenonsense

Thanks, @candicenonsense ! If you're still making updates, you can leave it in Draft state. Let me know whether you're finished with it or still working on it, or you can just set it to "Ready for review" if you're finished, at which point I'll recreate the PR in the internal repo.

FYI, we won't be publishing this PR directly, but I'll keep it open in case we need to iterate on the content. I'll close it when we publish the internal PR.

KarlErickson avatar Oct 17 '22 19:10 KarlErickson

@candicenonsense actually, I think you can ignore the merge conflict for now. Just let me know whether you're done with your edits. I've still got the original internal PR open, and I'll incorporate your edits there when you're ready. I'll let you know at that time whether I encounter any problems that need your input. Thanks!

KarlErickson avatar Oct 17 '22 19:10 KarlErickson

@KarlErickson I did one more resolve just now so that it should make sense - one section did not merge neatly. If it works for you I'd like to get this through and do a second iteration to add more content later on.

candicenonsense avatar Oct 17 '22 19:10 candicenonsense

@candicenonsense : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Oct 17 '22 19:10 prmerger-automator[bot]

Learn Build status updates of commit e6cf7fd:

:warning: Validation status: warnings

File Status Preview URL Details
articles/spring-apps/how-to-configure-enterprise-spring-cloud-gateway.md :warning:Warning Details
articles/spring-apps/how-to-use-enterprise-spring-cloud-gateway.md :white_check_mark:Succeeded

articles/spring-apps/how-to-configure-enterprise-spring-cloud-gateway.md

  • Line 58, Column 4: [Warning: file-not-found - See documentation] Invalid file link: 'media/how-to-configure-enterprise-spring-cloud-gateway/gateway-overview.png'.
  • Line 93, Column 4: [Warning: file-not-found - See documentation] Invalid file link: 'media/how-to-configure-enterprise-spring-cloud-gateway/gateway-configuration.png'.
  • Line 121, Column 4: [Warning: file-not-found - See documentation] Invalid file link: 'media/how-to-configure-enterprise-spring-cloud-gateway/gateway-sso-configuration.png'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

opbld31 avatar Oct 17 '22 19:10 opbld31

@candicenonsense no problem. I'll work on it this week and let you know if there are any issues. Thanks!

KarlErickson avatar Oct 17 '22 19:10 KarlErickson

Hi @candicenonsense - I've updated the PR with my edits and the images from the internal repo. Would you be able to recreate the screenshots? Two of them say "Azure Spring Cloud" still. Not sure if the third one needs updating for other reasons. Thanks!

KarlErickson avatar Oct 28 '22 02:10 KarlErickson

Learn Build status updates of commit 340f0fd:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/spring-apps/how-to-configure-enterprise-spring-cloud-gateway.md :white_check_mark:Succeeded
articles/spring-apps/how-to-use-enterprise-spring-cloud-gateway.md :white_check_mark:Succeeded
articles/spring-apps/media/how-to-configure-enterprise-spring-cloud-gateway/gateway-configuration.png :white_check_mark:Succeeded
articles/spring-apps/media/how-to-configure-enterprise-spring-cloud-gateway/gateway-overview.png :white_check_mark:Succeeded
articles/spring-apps/media/how-to-configure-enterprise-spring-cloud-gateway/gateway-sso-configuration.png :white_check_mark:Succeeded
articles/spring-apps/toc.yml :white_check_mark:Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

opbld32 avatar Oct 28 '22 02:10 opbld32

@microsoft-github-policy-service agree [company="VMware"]

candicenonsense avatar Oct 28 '22 20:10 candicenonsense

@KarlErickson yes, can update screenshots - last time we made them and someone on your side replaced everything with Contoso for company - how should I handle that?

candicenonsense avatar Oct 28 '22 20:10 candicenonsense

@microsoft-github-policy-service agree company="VMware"

candicenonsense avatar Oct 28 '22 20:10 candicenonsense

@candicenonsense : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Oct 28 '22 20:10 prmerger-automator[bot]

@candicenonsense it looks like these screenshots are pretty easy to recreate on our side, so we'll just have our vendor take care of it next week. If he can't reproduce these screens for some reason, we'll let you know. Thanks!

KarlErickson avatar Oct 28 '22 22:10 KarlErickson