azure-docs icon indicating copy to clipboard operation
azure-docs copied to clipboard

Update image-builder-json.md

Open fajterini opened this issue 2 years ago • 5 comments

Bicep code for windows update customization was not working missing '

fajterini avatar Oct 12 '22 11:10 fajterini

@fajterini : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Oct 12 '22 11:10 prmerger-automator[bot]

Learn Build status updates of commit 504b0ac:

:bulb: Validation status: suggestions

File Status Preview URL Details
articles/virtual-machines/linux/image-builder-json.md :bulb:Suggestion Details

articles/virtual-machines/linux/image-builder-json.md

  • Line 1155, Column 413: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/us/azure/virtual-machines/linux/image-builder-troubleshoot#authorization-error-creating-disk' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

opbld32 avatar Oct 12 '22 11:10 opbld32

@kof-f

Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

Court72 avatar Oct 12 '22 14:10 Court72

#reassign:@ericd-mst-github

cynthn avatar Oct 17 '22 16:10 cynthn

Fixes: https://github.com/MicrosoftDocs/azure-docs/pull/99675

cynthn avatar Oct 17 '22 18:10 cynthn

#sign-off

fajterini avatar Oct 19 '22 09:10 fajterini

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @kof-f

prmerger-automator[bot] avatar Oct 19 '22 09:10 prmerger-automator[bot]

Ah, this is my first merge request in github :( aaaa the sighoff was not meant for me.

fajterini avatar Oct 19 '22 09:10 fajterini

@fajterini : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Oct 19 '22 09:10 prmerger-automator[bot]

Learn Build status updates of commit 504b0ac:

:bulb: Validation status: suggestions

File Status Preview URL Details
articles/virtual-machines/linux/image-builder-json.md :bulb:Suggestion Details

articles/virtual-machines/linux/image-builder-json.md

  • Line 1155, Column 413: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/us/azure/virtual-machines/linux/image-builder-troubleshoot#authorization-error-creating-disk' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

opbld30 avatar Oct 19 '22 09:10 opbld30

#sign-off

ericd-mst-github avatar Dec 28 '22 20:12 ericd-mst-github

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @kof-f

prmerger-automator[bot] avatar Dec 28 '22 20:12 prmerger-automator[bot]

@ericd-mst-github

PRMerger will accept sign-off from the listed author only. However, if you are a Microsoft employee authorized to update this content, you can send a request to [email protected] for this PR to be merged. Include your role and an explanation of why the PR should be merged without approval from the listed author.

Court72 avatar Jan 03 '23 15:01 Court72

Hi @Court72 ,

I sent a request to the DL and I received the okay from Dennis. Now signing off.

#sign-off

ericd-mst-github avatar Jan 04 '23 00:01 ericd-mst-github

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @kof-f

prmerger-automator[bot] avatar Jan 04 '23 00:01 prmerger-automator[bot]

In review.

The PR Review team is reviewing your PR. As part of this process, we might make minor changes.

Don't make any commits during this review. When we finish, we’ll tag the PR creator in a comment if we find issues we can't address.

#label:"review-in-progress" #assign: @denrea

denrea avatar Jan 04 '23 00:01 denrea

@fajterini @kof-f - Merging per contributor's confirmation (via email and above) that they're authorized to make the change.

denrea avatar Jan 04 '23 00:01 denrea

Hi @denrea

Thanks, I just wanted to fix typo, but I don't now how to proper use github.

I will also delete branch to clean up :)

fajterini avatar Jan 04 '23 06:01 fajterini