azure-docs icon indicating copy to clipboard operation
azure-docs copied to clipboard

Update the link to indicates correct API version for AGIC/AzureIngressProhibitedTarget

Open mazgi opened this issue 3 years ago • 8 comments

The document indicates the link https://raw.githubusercontent.com/Azure/application-gateway-kubernetes-ingress/ae695ef9bd05c8b708cedf6ff545595d0b7022dc/crds/AzureIngressProhibitedTarget.yaml . However, this YAML file was written for "apiVersion: apiextensions.k8s.io/v1beta1," and it was outdated.

It seems the latest correct link is https://raw.githubusercontent.com/Azure/application-gateway-kubernetes-ingress/7b55ad194e7582c47589eb9e78615042e00babf3/crds/AzureIngressProhibitedTarget-v1-CRD-v1.yaml .

References

  • https://github.com/Azure/application-gateway-kubernetes-ingress/pull/1220

mazgi avatar Aug 26 '22 01:08 mazgi

@mazgi : Thanks for your contribution! The author(s) have been notified to review your proposed change. @caya

prmerger-automator[bot] avatar Aug 26 '22 04:08 prmerger-automator[bot]

@Jak-MS : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Aug 26 '22 16:08 prmerger-automator[bot]

@mscatyao

  • Can you review this PR?

IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

Jak-MS avatar Aug 26 '22 16:08 Jak-MS

It became a conflict while waiting for review, but I'm not in a position to judge the correct author. @mscatyao @greg-lindsay Could you resolve this? image

mazgi avatar Nov 11 '22 01:11 mazgi

@mazgi : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Nov 11 '22 15:11 prmerger-automator[bot]

#assign: @greg-lindsay

@greg-lindsay - can you review these changes? Thanks.

  • IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

Jak-MS avatar Nov 11 '22 15:11 Jak-MS

Users greg-lindsay are already assigned.

prmerger-automator[bot] avatar Nov 11 '22 15:11 prmerger-automator[bot]

Learn Build status updates of commit 9a6ad9e:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/application-gateway/ingress-controller-install-existing.md :white_check_mark:Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

opbld32 avatar Nov 11 '22 15:11 opbld32

#sign-off

greg-lindsay avatar Jan 24 '23 17:01 greg-lindsay