azure-docs icon indicating copy to clipboard operation
azure-docs copied to clipboard

Update harden-a-linux-image-to-remove-azure-guest-agent.md

Open shawntr opened this issue 6 months ago • 5 comments

As previously written lines 60 and 61 would delete /etc and /var/log as can be seen below:

sudo chroot /mnt/dev/$imagedevice/ rm -rf /etc/ walinuxagent.conf sudo chroot /mnt/dev/$imagedevice/ rm -rf /var/log/ walinuxagent.log

Additionally, the conf and log files should be waagent.conf and waagent.log.

Commands should be ran removing the space between the directory and conf and log file so that /etc and /var/log are not deleted and the proper file names used:

sudo chroot /mnt/dev/$imagedevice/ rm -rf /etc/waagent.conf sudo chroot /mnt/dev/$imagedevice/ rm -rf /var/log/waagent.log

shawntr avatar Jun 12 '25 16:06 shawntr

@shawntr : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. @vvenug

prmerger-automator[bot] avatar Jun 12 '25 16:06 prmerger-automator[bot]

Learn Build status updates of commit 2f23e36:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/confidential-computing/harden-a-linux-image-to-remove-azure-guest-agent.md :white_check_mark:Succeeded

For more details, please refer to the build report.

Also, the configuration name for the agent is waagent.conf so the correct lines should be: sudo chroot /mnt/dev/$imagedevice/ rm -rf /etc/waagent.conf sudo chroot /mnt/dev/$imagedevice/ rm -rf /var/log/waagent.log

With the curent lines you're asking our customers to delete the configuration files (all of them) and log files.

mitchcr avatar Jun 12 '25 17:06 mitchcr

Learn Build status updates of commit 89961be:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/confidential-computing/harden-a-linux-image-to-remove-azure-guest-agent.md :white_check_mark:Succeeded

For more details, please refer to the build report.

@FuzziWumpus @akashdubey-ms

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

v-dirichards avatar Jun 12 '25 20:06 v-dirichards

@FuzziWumpus @akashdubey-ms Could you review this proposed update to your article and enter #sign-off in a comment if it's ready to merge?

Thanks!

v-dirichards avatar Jul 01 '25 20:07 v-dirichards

#assign: @amruthavvenugopal

v-dirichards avatar Jul 01 '25 20:07 v-dirichards

The following users don't have valid GitHub IDs, or are not collaborators on this repo: amruthavvenugopal

prmerger-automator[bot] avatar Jul 01 '25 20:07 prmerger-automator[bot]

Learn Build status updates of commit 8d0c429:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/confidential-computing/harden-a-linux-image-to-remove-azure-guest-agent.md :white_check_mark:Succeeded

For more details, please refer to the build report.

@FuzziWumpus @akashdubey-ms

Can you review this old PR and determine whether it needs to be closed or merged?

@MicrosoftDocs/public-repo-pr-review-team

v-dirichards avatar Jul 15 '25 21:07 v-dirichards

Good catch! #sign-off

vinfnet avatar Jul 18 '25 16:07 vinfnet

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @vvenug

prmerger-automator[bot] avatar Jul 18 '25 16:07 prmerger-automator[bot]

Thanks @vinfnet Merging per email follow-up request @akashdubey-ms

ttorble avatar Jul 21 '25 15:07 ttorble