azure-docs icon indicating copy to clipboard operation
azure-docs copied to clipboard

Updated Synapse Source control doc

Open xiaoyuanzi1230 opened this issue 8 months ago • 4 comments

I am from MSFT Synapse CSS team, recently I worked with my one of customers. They found if they are using custom parameter file to extract notebook referenceName as parameter, and they have large number of notebooks, when they make the publish, it will pop up a message shows "Your ARM template exceeds the limit of 256 parameters. Please use custom parameters in your ARM template if you need to do CI/CD integration." but it actually doesn't block anything, but we don't have a doc to mention this situation so made the customer confused.

So submitting this pull request to update the doc upon my local test.

Thanks a lot

Mars Xiang

xiaoyuanzi1230 avatar Apr 24 '25 03:04 xiaoyuanzi1230

@xiaoyuanzi1230 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Apr 24 '25 03:04 prmerger-automator[bot]

Learn Build status updates of commit c79dfd9:

:warning: Validation status: warnings

File Status Preview URL Details
articles/synapse-analytics/cicd/source-control.md :warning:Warning Details
articles/synapse-analytics/cicd/media/parameters-exceed-limit-warning.png :white_check_mark:Succeeded

articles/synapse-analytics/cicd/source-control.md

  • Line 229, Column 22: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/synapse-analytics/cicd/continuous-integration-delivery#create-custom-parameters-in-the-workspace-template' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 229, Column 22: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/synapse-analytics/cicd/continuous-integration-delivery#create-custom-parameters-in-the-workspace-template' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@liudan66

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

v-dirichards avatar Apr 24 '25 14:04 v-dirichards

@liudan66 Could you review this proposed update to your article and enter #sign-off in a comment if it's ready to merge?

Thanks!

v-dirichards avatar Jun 20 '25 21:06 v-dirichards

@liudan66

Can you review this old PR and determine whether it needs to be closed or merged?

@MicrosoftDocs/public-repo-pr-review-team

v-dirichards avatar Jul 01 '25 15:07 v-dirichards

I sent email to the content owner today.

@MicrosoftDocs/public-repo-pr-review-team

ttorble avatar Aug 06 '25 09:08 ttorble

I sent a Teams message to the content owner today.

@MicrosoftDocs/public-repo-pr-review-team

v-dirichards avatar Aug 19 '25 21:08 v-dirichards

@sujie-ms

Can you review this old PR and determine whether it needs to be closed or merged?

IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge. If the changes no longer apply, add an explanation and a #please-close comment to close the PR.

@MicrosoftDocs/public-repo-pr-review-team

v-dirichards avatar Aug 21 '25 14:08 v-dirichards

Closing/reopening to check the CLA status

v-dirichards avatar Aug 21 '25 14:08 v-dirichards

@xiaoyuanzi1230 Thank you for your contribution. Would you take a moment to sign the Contributor License Agreement (CLA)? After the CLA is signed, someone can review your pull request. Thanks!

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

v-dirichards avatar Aug 21 '25 14:08 v-dirichards

Learn Build status updates of commit c79dfd9:

:warning: Validation status: warnings

File Status Preview URL Details
articles/synapse-analytics/cicd/source-control.md :warning:Warning Details
articles/synapse-analytics/cicd/media/parameters-exceed-limit-warning.png :white_check_mark:Succeeded

articles/synapse-analytics/cicd/source-control.md

  • Line 229, Column 22: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/synapse-analytics/cicd/continuous-integration-delivery#create-custom-parameters-in-the-workspace-template' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 229, Column 22: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/synapse-analytics/cicd/continuous-integration-delivery#create-custom-parameters-in-the-workspace-template' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

I have read the CLA Document and I hereby sign the CLA

xiaoyuanzi1230 avatar Aug 21 '25 14:08 xiaoyuanzi1230

@microsoft-github-policy-service agree

xiaoyuanzi1230 avatar Aug 21 '25 15:08 xiaoyuanzi1230

Learn Build status updates of commit 24a639e:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/synapse-analytics/cicd/media/parameters-exceed-limit-warning.png :white_check_mark:Succeeded
articles/synapse-analytics/cicd/source-control.md :white_check_mark:Succeeded

For more details, please refer to the build report.

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Image File This PR added or updated an image file(s).

prmerger-automator[bot] avatar Aug 21 '25 15:08 prmerger-automator[bot]

@sujie-ms

Can you review this old PR and determine whether it needs to be closed or merged?

@MicrosoftDocs/public-repo-pr-review-team

v-dirichards avatar Aug 28 '25 21:08 v-dirichards

@sujie-ms

Can you review this old PR and determine whether it needs to be closed or merged?

@MicrosoftDocs/public-repo-pr-review-team

v-dirichards avatar Oct 02 '25 15:10 v-dirichards