azure-docs icon indicating copy to clipboard operation
azure-docs copied to clipboard

Update concepts-device-authentication.md

Open johnsoucy-birket opened this issue 1 year ago • 5 comments

Added a clarification regarding each device needing unique id and unique key. Our team lost a week because we thought the c sdk might be using the group key behind the scenes and creating the needed unique values. Lesson learned, sharing the lesson.

johnsoucy-birket avatar Oct 06 '24 03:10 johnsoucy-birket

@johnsoucy-birket : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Oct 06 '24 03:10 prmerger-automator[bot]

Learn Build status updates of commit 42c052a:

:warning: Validation status: warnings

File Status Preview URL Details
articles/iot-central/core/concepts-device-authentication.md :warning:Warning Details

articles/iot-central/core/concepts-device-authentication.md

  • Line 71, Column 134: [Warning: disallowed-html-tag - See documentation] HTML tag 'device' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Learn Build status updates of commit b68cdae:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/iot-central/core/concepts-device-authentication.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

@dominicbetts

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

ShannonLeavitt avatar Oct 07 '24 15:10 ShannonLeavitt

Hi @johnsoucy-birket - thanks for the additional feedback. I've made some changes in some other areas as well to highlight that devices must have unique IDs - the changes should publish later today. See:

  • https://learn.microsoft.com/en-us/azure/iot-central/core/overview-iot-central-developer#register-a-device
  • https://learn.microsoft.com/en-us/azure/iot-central/core/concepts-device-authentication
  • https://learn.microsoft.com/en-us/azure/iot-central/core/concepts-device-authentication#sas-enrollment-group

dominicbetts avatar Oct 21 '24 09:10 dominicbetts

I sent an email to the content owner today.

@MicrosoftDocs/public-repo-pr-review-team

v-ccolin avatar Nov 22 '24 09:11 v-ccolin

Hi @johnsoucy-birket - I made some further changes after your most recent feedback. I'm closing this PR for now as it's been superseded by the one that I created. Please feel free to reopen it if you have any addition suggestions or comments. Thanks for your help and feedback!

dominicbetts avatar Nov 22 '24 09:11 dominicbetts

#please-close

dominicbetts avatar Nov 22 '24 09:11 dominicbetts