azure-docs icon indicating copy to clipboard operation
azure-docs copied to clipboard

Update to enterprise ca certificate requirements for Azure Premium Firewall

Open Chris-Hailes opened this issue 1 year ago • 8 comments

Based on the outcomes of Microsoft Support Ticket #2408310030000153

The default subordinate certificate template does not meet the requirements for Azure Firewall Premium TLS inspection certificate. A new certificate template is required to have the Key Usage extension marked as critical.

Chris-Hailes avatar Sep 07 '24 06:09 Chris-Hailes

@microsoft-github-policy-service agree

Chris-Hailes avatar Sep 07 '24 06:09 Chris-Hailes

@Chris-Hailes : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Sep 07 '24 06:09 prmerger-automator[bot]

Learn Build status updates of commit 2f5d877:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/firewall/media/premium-deploy-certificates-enterprise-ca/certificate-template-key-usage-extension.png :white_check_mark:Succeeded
articles/firewall/premium-deploy-certificates-enterprise-ca.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Image File This PR added or updated an image file(s).

prmerger-automator[bot] avatar Sep 07 '24 06:09 prmerger-automator[bot]

@vhorne

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

Court72 avatar Sep 09 '24 15:09 Court72

Learn Build status updates of commit fe11f4c:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/firewall/media/premium-deploy-certificates-enterprise-ca/certificate-template-key-usage-extension.png :white_check_mark:Succeeded
articles/firewall/premium-deploy-certificates-enterprise-ca.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Image File This PR added or updated an image file(s).

prmerger-automator[bot] avatar Sep 22 '24 23:09 prmerger-automator[bot]

@vhorne

Can you review this old PR and determine whether it needs to be closed or merged?

@MicrosoftDocs/public-repo-pr-review-team

PMEds28 avatar Oct 20 '24 09:10 PMEds28

I sent an email to the content owner today.

@MicrosoftDocs/public-repo-pr-review-team

v-ccolin avatar Nov 27 '24 09:11 v-ccolin

@PMEds28 @v-ccolin @Chris-Hailes Please notice that I've already reviewed this PR and made suggested changes. These changes have yet to be reviewed by the PR author.

vhorne avatar Dec 02 '24 14:12 vhorne

@PMEds28 @v-ccolin @Chris-Hailes Please notice that I've already reviewed this PR and made suggested changes. These changes have yet to be reviewed by the PR author.

@vhorne I don't see any suggested edits can you advise where you've made these suggested changes?

Chris-Hailes avatar Dec 02 '24 21:12 Chris-Hailes

@Court72 Can you assist here?

vhorne avatar Dec 02 '24 22:12 vhorne

@vhorne - The PR reviewers also don't see any suggested changes. We're happy to make them, however. If you're unable to add the suggestions in the Files Changed view, could you paste a screenshot?

ShannonLeavitt avatar Dec 03 '24 18:12 ShannonLeavitt

image image

vhorne avatar Dec 04 '24 21:12 vhorne

Learn Build status updates of commit ffe67c2:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/firewall/media/premium-deploy-certificates-enterprise-ca/certificate-template-key-usage-extension.png :white_check_mark:Succeeded
articles/firewall/premium-deploy-certificates-enterprise-ca.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Image File This PR added or updated an image file(s).

prmerger-automator[bot] avatar Dec 04 '24 22:12 prmerger-automator[bot]

Learn Build status updates of commit 9f91d4f:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/firewall/media/premium-deploy-certificates-enterprise-ca/certificate-template-key-usage-extension.png :white_check_mark:Succeeded
articles/firewall/premium-deploy-certificates-enterprise-ca.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Image File This PR added or updated an image file(s).

prmerger-automator[bot] avatar Dec 04 '24 22:12 prmerger-automator[bot]

@vhorne,

I committed your suggestions based on the screenshots. Can you take a look and confirm that I caught them all? And #sign-off if this PR is ready to merge.

Thanks!

Court72 avatar Dec 04 '24 22:12 Court72

#sign-off

vhorne avatar Dec 05 '24 17:12 vhorne

Learn Build status updates of commit 8d8ac41:

:warning: Validation status: warnings

File Status Preview URL Details
articles/synapse-analytics/sql/resources-self-help-sql-on-demand.md :warning:Warning Details
articles/firewall/media/premium-deploy-certificates-enterprise-ca/certificate-template-key-usage-extension.png :white_check_mark:Succeeded
articles/firewall/premium-deploy-certificates-enterprise-ca.md :white_check_mark:Succeeded

articles/synapse-analytics/sql/resources-self-help-sql-on-demand.md

  • Line 1115, Column 48: [Warning: disallowed-html-tag - See documentation] HTML tag 'workspaceName' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Closing/reopening to refresh the build

v-dirichards avatar Dec 05 '24 21:12 v-dirichards

Learn Build status updates of commit 8d8ac41:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/firewall/media/premium-deploy-certificates-enterprise-ca/certificate-template-key-usage-extension.png :white_check_mark:Succeeded
articles/firewall/premium-deploy-certificates-enterprise-ca.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Image File This PR added or updated an image file(s).

prmerger-automator[bot] avatar Dec 05 '24 21:12 prmerger-automator[bot]