azure-docs icon indicating copy to clipboard operation
azure-docs copied to clipboard

Update opentelemetry-agents.md

Open jordanbean-msft opened this issue 1 year ago • 7 comments

Added Terraform example for Application Insights

jordanbean-msft avatar Jul 02 '24 18:07 jordanbean-msft

@jordanbean-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Jul 02 '24 18:07 prmerger-automator[bot]

Learn Build status updates of commit 6034422:

:warning: Validation status: warnings

File Status Preview URL Details
articles/container-apps/opentelemetry-agents.md :warning:Warning Details

articles/container-apps/opentelemetry-agents.md

  • Line 139, Column 1: [Warning: invalid-tab-group - See documentation] Tab group with different tab id set.
  • Line 194, Column 1: [Warning: invalid-tab-group - See documentation] Tab group with different tab id set.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Learn Build status updates of commit a18d224:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/container-apps/opentelemetry-agents.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

Learn Build status updates of commit 8c388f4:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/container-apps/opentelemetry-agents.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

Learn Build status updates of commit acca1ed:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/container-apps/opentelemetry-agents.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

@craigshoemaker Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

Jak-MS avatar Jul 02 '24 21:07 Jak-MS

Learn Build status updates of commit 30bbd5f:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/container-apps/opentelemetry-agents.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

@craigshoemaker

Can you review this old PR and determine whether it needs to be closed or merged?

Court72 avatar Aug 22 '24 15:08 Court72

Waiting for approval from product team.

craigshoemaker avatar Aug 30 '24 21:08 craigshoemaker

ping @craigshoemaker - checking on this. see approval from @michaelkira from today.

Jak-MS avatar Sep 25 '24 15:09 Jak-MS

Thanks, @jordanbean-msft!

#sign-off

craigshoemaker avatar Dec 13 '24 21:12 craigshoemaker

@jordanbean-msft @craigshoemaker - a couple items:

  1. this PR had merge conflicts and I resolved them, but please check to see that I didn't make any inadvertent mistakes.
  2. we can't verify (or view) tabbed content in the public repo. Usually we don't allow it here and require the commits to be moved to the private repo. That said, since this is just adding a tab to an existing structure, I think it should render okay. STILL, you will need to verify that it is rendering correctly after it goes live and if not, open another PR to address any issues. thanks!

Jak-MS avatar Dec 13 '24 22:12 Jak-MS

Learn Build status updates of commit 8d92674:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/container-apps/opentelemetry-agents.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please: