azure-docs icon indicating copy to clipboard operation
azure-docs copied to clipboard

Panderson/pure storage link changes

Open gungazoo opened this issue 1 year ago • 19 comments

The links to the Pure Storage documentation have changed.

gungazoo avatar Jun 27 '24 12:06 gungazoo

@gungazoo : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Jun 27 '24 12:06 prmerger-automator[bot]

Learn Build status updates of commit 046a838:

:x: Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
:x:Error Details

  • [Error: CannotMergeCommit] Cannot merge commit 046a838a0dcb03fcda6dbfac0134531ef83e94c1 in branch panderson/pure-storage-link-changes of repository https://github.com/gungazoo/azure-docs-tools-repo into branch main (commit 6e77ce8c588b381f69359aa355b9fb8759ff98c9). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Learn Build status updates of commit 3886051:

:x: Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
:x:Error Details

  • [Error: CannotMergeCommit] Cannot merge commit 38860516a49593528af473aa27f4f82a3cc80200 in branch panderson/pure-storage-link-changes of repository https://github.com/gungazoo/azure-docs-tools-repo into branch main (commit 6e77ce8c588b381f69359aa355b9fb8759ff98c9). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gungazoo - Thanks for your pull request. A member of the content team will review it.

Court72 avatar Jun 27 '24 15:06 Court72

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

Court72 avatar Jun 27 '24 15:06 Court72

I'll review this content and provide feedback.

jjaygbay1 avatar Jun 27 '24 16:06 jjaygbay1

@jjaygbay1 @gungazoo

Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

v-ccolin avatar Aug 22 '24 10:08 v-ccolin

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @jjaygbay1

prmerger-automator[bot] avatar Aug 22 '24 10:08 prmerger-automator[bot]

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @jjaygbay1

prmerger-automator[bot] avatar Aug 22 '24 10:08 prmerger-automator[bot]

@Court72 To approve this PR to merge the contribution, author must resolve the conflict.

jjaygbay1 avatar Sep 05 '24 18:09 jjaygbay1

Learn Build status updates of commit bd4d463:

:warning: Validation status: warnings

File Status Preview URL Details
articles/azure-vmware/configure-vm-tools-repo.md :warning:Warning Details
articles/azure-vmware/ecosystem-external-storage-solutions.md :white_check_mark:Succeeded
articles/azure-vmware/media/run-command/tools-repo-all-products.png :white_check_mark:Succeeded
articles/azure-vmware/media/run-command/tools-repo-files.png :white_check_mark:Succeeded
articles/azure-vmware/media/run-command/tools-repo-search.png :white_check_mark:Succeeded
articles/azure-vmware/media/run-command/tools-repo-select-tools.png :white_check_mark:Succeeded
articles/azure-vmware/media/run-command/tools-repo-windows-package.png :white_check_mark:Succeeded

articles/azure-vmware/configure-vm-tools-repo.md

  • Line 65, Column 45: [Warning: file-not-found - See documentation] Invalid file link: 'template-howto.md'.
  • Line 11, Column 10: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://review.learn.microsoft.com/help/contribute/contribute-how-to-write-seo-basics?branch=main' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Thanks, @jjaygbay1. For convenience, I resolved the merge conflict.

Court72 avatar Sep 05 '24 20:09 Court72

Thanks, @jjaygbay1. For convenience, I resolved the merge conflict.

Thank you, @Court72.

jjaygbay1 avatar Sep 16 '24 12:09 jjaygbay1

Hi @gungazoo and @jjaygbay1 ,

As this is a new article, we'll need the commits to be moved to the private repo - azure-docs-pr so we can do a full review with staging and acrolinx. @jjaygbay1 - can you move the commits and serve as the author? (let us know if you need assistance).

Some issues of note: the new article is missing some required metadata fields which will need to be added. Also, all new articles must have an entry in a toc.yml ... and there might be other issues to resolve before these additions can be merged, but we will do a full review after the commits are moved and a new PR is opened in the private repo.

Jak-MS avatar Sep 16 '24 20:09 Jak-MS

#hold-off

Jak-MS avatar Sep 16 '24 20:09 Jak-MS

You typed hold-off, but the PR wasn't signed off, so nothing was changed.

prmerger-automator[bot] avatar Sep 16 '24 20:09 prmerger-automator[bot]

I emailed the owner today.

ShannonLeavitt avatar Oct 03 '24 15:10 ShannonLeavitt

@ShannonLeavitt The article is not ready for publication. With conflicting priorities, I'm afraid I don't have time to create this new article this week. I'll get to it next week.

jjaygbay1 avatar Oct 03 '24 17:10 jjaygbay1

@jjaygbay1 - If it helps, you can find instructions to move the commits to the private repo here.

ShannonLeavitt avatar Oct 17 '24 14:10 ShannonLeavitt

I sent an email to the content owner today.

@MicrosoftDocs/public-repo-pr-review-team

v-ccolin avatar Nov 22 '24 09:11 v-ccolin

@jjaygbay1 Can you review this old PR and determine whether it needs to be closed or merged?

IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge. If the changes no longer apply, add an explanation and a #please-close comment to close the PR.

@MicrosoftDocs/public-repo-pr-review-team

v-dirichards avatar Jan 17 '25 20:01 v-dirichards

I sent email to the content owner today.

@MicrosoftDocs/public-repo-pr-review-team

ttorble avatar Feb 17 '25 16:02 ttorble

I sent an email to the content owner today.

@MicrosoftDocs/public-repo-pr-review-team

v-ccolin avatar Mar 09 '25 09:03 v-ccolin

@v-ccolin, the author needs to resolve the conflict.

jjaygbay1 avatar Mar 10 '25 01:03 jjaygbay1

Learn Build status updates of commit 5376b41:

:warning: Validation status: warnings

File Status Preview URL Details
articles/azure-vmware/configure-vm-tools-repo.md :warning:Warning Details
articles/azure-vmware/media/run-command/tools-repo-all-products.png :white_check_mark:Succeeded
articles/azure-vmware/media/run-command/tools-repo-files.png :white_check_mark:Succeeded
articles/azure-vmware/media/run-command/tools-repo-search.png :white_check_mark:Succeeded
articles/azure-vmware/media/run-command/tools-repo-select-tools.png :white_check_mark:Succeeded
articles/azure-vmware/media/run-command/tools-repo-windows-package.png :white_check_mark:Succeeded

articles/azure-vmware/configure-vm-tools-repo.md

  • Line 65, Column 45: [Warning: file-not-found - See documentation] Invalid file link: 'template-howto.md'.
  • Line 11, Column 10: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://review.learn.microsoft.com/help/contribute/contribute-how-to-write-seo-basics?branch=main' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Thanks, @jjaygbay1. For convenience, I resolved the merge conflict.

Because this PR adds a new article, you need to move the commits to the private repo, azure-docs-pr, so that we can do a full review with staging and Acrolinx. Can you move the commits and serve as the author? (let us know if you need assistance).

See https://github.com/MicrosoftDocs/azure-docs/pull/123549#issuecomment-2353987439 for more info.

Court72 avatar Mar 10 '25 15:03 Court72

I sent an email to the content owner today.

@MicrosoftDocs/public-repo-pr-review-team

v-ccolin avatar Apr 06 '25 10:04 v-ccolin

#sign-off

jjaygbay1 avatar Apr 07 '25 16:04 jjaygbay1

@jjaygbay1 This PR needs to be pulled into the private repo, azure-docs-pr, so that we can do a full review with staging and Acrolinx.

Can you move the commits and serve as the author? (let us know if you need assistance).

See comment above for more info.

v-dirichards avatar Apr 07 '25 20:04 v-dirichards

#hold-off

v-dirichards avatar Apr 07 '25 21:04 v-dirichards