Wrong Limits link firewall-best-practices.md
The link to the Azure Firewall limits, seems to be the wrong one
@lanicolas : Thanks for your contribution! The author(s) have been notified to review your proposed change.
Learn Build status updates of commit e3d2ea5:
:warning: Validation status: warnings
| File | Status | Preview URL | Details |
|---|---|---|---|
| articles/firewall/firewall-best-practices.md | :warning:Warning | Details |
articles/firewall/firewall-best-practices.md
- Line 20, Column 301: [Warning: file-not-found - See documentation]
Invalid file link: '../includes/firewall-limits.md'.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
@vhorne
Can you review the proposed changes? Note that the validation warning must be resolved before merge.
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team
@vhorne,
Thanks for reviewing! For convenience, I committed your suggestion.
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
Learn Build status updates of commit 7a126f2:
:warning: Validation status: warnings
| File | Status | Preview URL | Details |
|---|---|---|---|
| articles/firewall/firewall-best-practices.md | :warning:Warning | Details |
articles/firewall/firewall-best-practices.md
- Line 20, Column 301: [Warning: link-out-of-scope - See documentation]
File 'includes/firewall-limits.md' referenced by link '../../includes/firewall-limits.md' will not be built because it is not included in build scope.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
#sign-off
Learn Build status updates of commit 555b012:
:white_check_mark: Validation status: passed
| File | Status | Preview URL | Details |
|---|---|---|---|
| articles/firewall/firewall-best-practices.md | :white_check_mark:Succeeded |
For more details, please refer to the build report.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
@vhorne - can you take a look at the change I made and let me know you approve? thanks.
@vhorne - can you take a look at the change I made and let me know you approve? thanks.
@Jak-MS That Resource Manage article just links to the same source include file that I originally linked to.
### Azure Firewall limits
[!INCLUDE [azure-firewall-limits](../../../includes/firewall-limits.md)]
What's the advantage of doing that?
@vhorne, Jak provides an explanation here: https://github.com/MicrosoftDocs/azure-docs/pull/123544#discussion_r1678425198. In short, include files won't render by themselves; you have to link to a standalone article that includes the file.
hi @vhorne - sorry, my explanation got buried in the commit comments. Here it is:
@vhorne - includes in the /includes/ folder aren't built (rendered) by themselves. They're only available for viewing on the site when they're inside an article. You can add the include into this page or link to another page that already contains the include, but you can't link directly to the include file. I've provided a jump link to the firewall limits on the Azure subscription service limits page: https://learn.microsoft.com/en-us/azure/azure-resource-manager/management/azure-subscription-service-limits#azure-firewall-limits
#sign-off