azure-docs icon indicating copy to clipboard operation
azure-docs copied to clipboard

Feature/quickstart aca 2

Open ravick4u opened this issue 1 year ago • 19 comments

New page added under quick start to create azure container app with terraform

ravick4u avatar May 18 '24 15:05 ravick4u

Learn Build status updates of commit a48d425:

:warning: Validation status: warnings

File Status Preview URL Details
articles/active-directory-b2c/microsoft-graph-operations.md :warning:Warning Details
articles/container-apps/quickstart-terraform.md :warning:Warning Details
articles/container-apps/media/connect-apps/azure-container-apps-quickstart-terraform.png :white_check_mark:Succeeded
articles/container-apps/TOC.yml :white_check_mark:Succeeded

articles/active-directory-b2c/microsoft-graph-operations.md

  • Line 265, Column 1: [Warning: invalid-code] The code snippet "~/ms-identity-dotnetcore-b2c-account-management/src/Program.cs" could not be found.
  • Line 269, Column 1: [Warning: invalid-code] The code snippet "~/ms-identity-dotnetcore-b2c-account-management/src/Services/UserService.cs" could not be found.

articles/container-apps/quickstart-terraform.md

  • Line 105, Column 5: [Warning: file-not-found - See documentation] Invalid file link: './media/connect-apps/azure-container-apps-quickstart-terraform'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Learn Build status updates of commit 6c2ca45:

:warning: Validation status: warnings

File Status Preview URL Details
articles/active-directory-b2c/microsoft-graph-operations.md :warning:Warning Details
articles/container-apps/media/connect-apps/azure-container-apps-quickstart-terraform.png :white_check_mark:Succeeded
articles/container-apps/quickstart-terraform.md :white_check_mark:Succeeded
articles/container-apps/TOC.yml :white_check_mark:Succeeded

articles/active-directory-b2c/microsoft-graph-operations.md

  • Line 265, Column 1: [Warning: invalid-code] The code snippet "~/ms-identity-dotnetcore-b2c-account-management/src/Program.cs" could not be found.
  • Line 269, Column 1: [Warning: invalid-code] The code snippet "~/ms-identity-dotnetcore-b2c-account-management/src/Services/UserService.cs" could not be found.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@ravick4u - Thanks for your pull request. A member of the content team will review it.

Court72 avatar May 20 '24 15:05 Court72

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

Court72 avatar May 20 '24 15:05 Court72

@craigshoemaker

Can you review this old PR and determine whether it needs to be closed or moved into the private repo for review and merge?

Court72 avatar Aug 27 '24 15:08 Court72

@Court72 @craigshoemaker, please let me know why the branch has not been merged. Let me know if anything is pending on my end.

ravick4u avatar Sep 07 '24 12:09 ravick4u

I sent an email to the content owner today.

Court72 avatar Sep 11 '24 15:09 Court72

@craigshoemaker

Can you review this old PR and determine whether it needs to be closed or merged?

@MicrosoftDocs/public-repo-pr-review-team

ttorble avatar Nov 22 '24 08:11 ttorble

I sent an email to the content owner today.

Court72 avatar Dec 23 '24 19:12 Court72

@craigshoemaker

Can you review this PR and let us know if it needs to be merged or closed?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"

Thanks! @MicrosoftDocs/public-repo-pr-review-team

v-dirichards avatar Jan 23 '25 16:01 v-dirichards

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @, @ravick4u

prmerger-automator[bot] avatar Jan 23 '25 16:01 prmerger-automator[bot]

I sent an email to the service owner today.

Court72 avatar Feb 18 '25 00:02 Court72

I sent an email to the content owner today.

@MicrosoftDocs/public-repo-pr-review-team

v-ccolin avatar Mar 07 '25 11:03 v-ccolin

I sent an email to the content owner today.

@MicrosoftDocs/public-repo-pr-review-team

v-ccolin avatar Apr 06 '25 08:04 v-ccolin

@craigshoemaker

Can you review this old PR and determine whether it needs to be closed or merged?

PMEds28 avatar Apr 30 '25 09:04 PMEds28

I sent an email to the content owner today.

@MicrosoftDocs/public-repo-pr-review-team

v-ccolin avatar May 22 '25 07:05 v-ccolin

I sent an email to the content owner today.

@MicrosoftDocs/public-repo-pr-review-team

v-ccolin avatar Jun 20 '25 07:06 v-ccolin

It's been a year since this PR has been open. This is very frustrating that no one is approving this PR or letting me know if anything is wrong with this. @v-ccolin @PMEds28 @v-regandowner @Court72 @v-dirichards

ravick4u avatar Jun 23 '25 23:06 ravick4u

@craigshoemaker for review, thanks.

v-dirichards avatar Jun 24 '25 15:06 v-dirichards

@ravick4u - Hey Ravi - sorry for incredibly long time with no response. This PR as it stands doesn't follow the direction we're going with for quickstarts and needs to be updated to follow how we write tutorials in terms of publishing sample code, etc.

I am going to #please-close this PR, but what I can do is bring in your commits into our internal system and edit what you have from there. This way, you'll get credit for your contributions in the git commit history when we publish a tutorial similar to your draft.

craigshoemaker avatar Jul 03 '25 20:07 craigshoemaker