azure-docs icon indicating copy to clipboard operation
azure-docs copied to clipboard

Update upgrade-aks-cluster.md

Open ramdaspotale opened this issue 1 year ago • 5 comments

Update upgrade-aks-cluster.md to fix --drain-timeout parameter on az aks nodepool update.

according to https://learn.microsoft.com/en-us/cli/azure/aks/nodepool?view=azure-cli-latest#az-aks-nodepool-update and also from my experience correct parameter to set drain timeout is --drain-timeout and not --drainTimeoutInMinutes.

ramdaspotale avatar Apr 29 '24 05:04 ramdaspotale

@ramdaspotale : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Apr 29 '24 05:04 prmerger-automator[bot]

Learn Build status updates of commit 85fdbab:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/aks/upgrade-aks-cluster.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

Hey @schaffererin Can you please approve this PR?

ramdaspotale avatar Apr 29 '24 14:04 ramdaspotale

Learn Build status updates of commit 9d4b5d0:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/aks/upgrade-aks-cluster.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

@schaffererin

  • Can you review this PR?
  • IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

Jak-MS avatar Apr 29 '24 21:04 Jak-MS

Hey @schaffererin Can you please approve this PR?

ramdaspotale avatar Jun 04 '24 15:06 ramdaspotale

@ramdaspotale - Can you respond to the requested changes or let us know if you would like us to commit them?

@schaffererin - When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

Court72 avatar Jun 26 '24 15:06 Court72

Learn Build status updates of commit fe8e5fb:

:x: Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
:x:Error Details

  • [Error: CannotMergeCommit] Cannot merge commit fe8e5fbc11efa247e4112b19cd90f5174f88599a in branch patch-1 of repository https://github.com/ramdaspotale/azure-docs into branch main (commit 2ab6cc42a7d66077ddea90801b9b2caf72b3bd87). Please follow this documentation: https://help.github.com/articles/resolving-a-merge-conflict-using-the-command-line/ to use git.exe to resolve you content conflicts locally and then push to remote.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Court72 @schaffererin i think someone else has already merged same changes and my PR has merge conflicts.

https://github.com/MicrosoftDocs/azure-docs/commit/4835707e758fc625714c393b510b973efe221d92

ramdaspotale avatar Jun 26 '24 15:06 ramdaspotale

@ramdaspotale - You're correct - the change is already live. We'll close this PR. Thanks for contributing!

Court72 avatar Jun 26 '24 20:06 Court72