azure-docs icon indicating copy to clipboard operation
azure-docs copied to clipboard

Update functions-reference-powershell.md

Open Aghyad85 opened this issue 1 year ago • 5 comments

This is related to internal WI 578. I made these changes after consulting anatolib .

Aghyad85 avatar Mar 21 '24 10:03 Aghyad85

@Aghyad85 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Mar 21 '24 10:03 prmerger-automator[bot]

@Aghyad85 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Mar 21 '24 15:03 prmerger-automator[bot]

Learn Build status updates of commit 244aa01:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/azure-functions/functions-reference-powershell.md :white_check_mark:Succeeded

For more details, please refer to the build report.

For any questions, please:

@eamonoreilly

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

Court72 avatar Mar 21 '24 15:03 Court72

Discussed with Aghyad and it could be reworded if Aghyad updates his branch with these changes.

Can this be reworded?

  • System Assigned Identity :Using a user-assigned identity requires a bit more work. The easiest thing to do is to find the “Client ID” property of the user-managed identity and pass it to the Connect-AzAccount cmdlet as an AccountId value, for example:

I would suggest that having a new section for User-Assigned identity and having some text like this might be better.

E.G

  • User Assigned Identity :

There are two recommended approaches to using User Assigned identity. The first option is to find the “Client ID” property of the user-managed identity and pass it to the Connect-AzAccount cmdlet as an AccountId value, for example:

Connect-AzAccount -Identity -AccountId <Client ID>

If hardcoding the ID is not an option, then please consider these steps:

  1. Enable the system assigned identity as well.
  2. Make the system assigned identity a Reader on the user assigned identity.
  3. In the profile.ps1 file, replace:
Connect-AzAccount -Identity 

with:

    Connect-AzAccount -Identity
    $identity = Get-AzUserAssignedIdentity -ResourceGroupName … -Name … # retrieve the specific user assigned identity
    Connect-AzAccount -Identity -AccountId $identity.Id

FinVamp1 avatar Mar 21 '24 19:03 FinVamp1

Hi. Who needs to take action to advance this PR, @Aghyad85?

@eamonoreilly @FinVamp1

American-Dipper avatar Apr 23 '24 23:04 American-Dipper

@eamonoreilly

Can you review this old PR and determine whether it needs to be closed or merged?

Court72 avatar May 17 '24 15:05 Court72

@Aghyad85 can you update the PR with my changes please?

FinVamp1 avatar May 17 '24 15:05 FinVamp1