azure-docs icon indicating copy to clipboard operation
azure-docs copied to clipboard

1 - Add an Azure Linux node pool - code example updates needed

Open msfttklingenberg opened this issue 2 years ago • 3 comments

recommend updating the code block to the following. The example nodepool name is longer than 12 characters and when upper/lower case was combined, the command still failed. the --node-count line is also missing a trailing backslash.

For the pre-requisites, I had to upgrade from az-cli 2.48.1 to az-cli 2.49.0 for it to work. The document just says "you need the latest version..." the release notes for az-cli do not specify this change, but 2.49.0 seems to be where the change happened. https://learn.microsoft.com/en-us/cli/azure/release-notes-azure-cli?view=azure-cli-latest#may-23-2023

NOTE: none of my backslashes are showing up in the code below.

az aks nodepool add
--resource-group testAzureLinuxResourceGroup
--cluster-name testAzureLinuxCluster
--name myazurelinux
--node-count 3
--os-sku AzureLinux


Document Details

Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

msfttklingenberg avatar May 31 '23 18:05 msfttklingenberg

@msfttklingenberg thank you for this feedback, we will make sure to incorporate it ASAP! Can you please clarify what you mean by "none of my backslashes are showing up in the code below"?

htaubenfeld avatar May 31 '23 21:05 htaubenfeld

@msfttklingenberg Thanks for your feedback! We will investigate and update as appropriate.

@htaubenfeld thanks for your quick responses.

SaibabaBalapur-MSFT avatar Jun 01 '23 04:06 SaibabaBalapur-MSFT

@msfttklingenberg thank you for this feedback, we will make sure to incorporate it ASAP! Can you please clarify what you mean by "none of my backslashes are showing up in the code below"?

sure, I can clarify that. when I put the backslashes in, they disappear, but this may only be a GitHub display issue. I expected there to be a backslash at the end of each line in my code example (except for the last line). Below is a screenshot of how it is displayed incorrectly.

image

msfttklingenberg avatar Jun 01 '23 12:06 msfttklingenberg

#reassign:schaffererin

schaffererin avatar Jun 06 '23 21:06 schaffererin

Hi, @msfttklingenberg, thank you for your feedback. I updated the doc according to your feedback, and you can review my edits in this PR. The updates will be live in the documentation shortly. I will now close this GitHub issue. Thanks again!

#please-close

schaffererin avatar Jun 06 '23 21:06 schaffererin