azure-docs
azure-docs copied to clipboard
Update Sample YAML in prometheus-remote-write-managed-identity.md
The sample YAML in the Deploy Side car and configure remote write on the Prometheus server section appears to be wrong. livenessProbe should contain httpGet, initialDelaySeconds, and timeoutSeconds. Presently, the latter two are values under httpGet, which makes this YAML invalid. This exact same issue occurs in the readinessProbe value below, too. The Prometheus spec used in this step of the guide can be seen here, laying out what I am claiming here:
https://docs.okd.io/latest/rest_api/monitoring_apis/prometheus-monitoring-coreos-com-v1.html#spec-containers-livenessprobe https://docs.okd.io/latest/rest_api/monitoring_apis/prometheus-monitoring-coreos-com-v1.html#spec-containers-readinessprobe
@that-guy-is-it : Thanks for your contribution! The author(s) have been notified to review your proposed change.
Learn Build status updates of commit e7a28b0:
:white_check_mark: Validation status: passed
| File | Status | Preview URL | Details |
|---|---|---|---|
| articles/azure-monitor/essentials/prometheus-remote-write-managed-identity.md | :white_check_mark:Succeeded |
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:
- Try searching the learn.microsoft.com contributor guides
- Post your question in the Learn support channel
@bwren,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team
#sign-off