azure-docs icon indicating copy to clipboard operation
azure-docs copied to clipboard

Unclear description of "ExpressRoute Circuit Owner".

Open SebastianClaesson opened this issue 3 years ago • 10 comments

There are mentions of a "Circuit Owner". However, there's no such role in Azure or a attribute on the ExpressRoute.

Added a note on each of the documentations that explains the defintion of "Cricuit owner" on each "how to peer an express route cross-subscription".

Definition of the Circuit Owner: Circuit Owner is simply any user(s) with the access:

  • Microsoft.Network/expressRouteCircuits/authorizations/write
  • Microsoft.Network/expressRouteCircuits/authorizations/read
  • Microsoft.Network/expressRouteCircuits/authorizations/delete

This could for instance be any user with Contributor, Owner or Network Contributor role access on the ExpressRoute resource (inherited or directly).

SebastianClaesson avatar Dec 13 '22 13:12 SebastianClaesson

@SebastianClaesson : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Dec 13 '22 13:12 prmerger-automator[bot]

Learn Build status updates of commit 28f8eb8:

:warning: Validation status: warnings

File Status Preview URL Details
articles/expressroute/expressroute-howto-linkvnet-arm.md :warning:Warning Details
articles/expressroute/expressroute-howto-linkvnet-classic.md :warning:Warning Details
articles/expressroute/expressroute-howto-linkvnet-portal-resource-manager.md :warning:Warning Details

articles/expressroute/expressroute-howto-linkvnet-arm.md

  • Line 92, Column 46: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/role-based-access-control/built-in-roles#contributor' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 92, Column 155: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/role-based-access-control/built-in-roles#owner' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 92, Column 255: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/role-based-access-control/built-in-roles#network-contributor' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 92, Column 46: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/role-based-access-control/built-in-roles#contributor' will be broken in isolated environments. Replace with a relative link.
  • Line 92, Column 155: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/role-based-access-control/built-in-roles#owner' will be broken in isolated environments. Replace with a relative link.
  • Line 92, Column 255: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/role-based-access-control/built-in-roles#network-contributor' will be broken in isolated environments. Replace with a relative link.

articles/expressroute/expressroute-howto-linkvnet-classic.md

  • Line 87, Column 46: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/role-based-access-control/built-in-roles#contributor' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 87, Column 155: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/role-based-access-control/built-in-roles#owner' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 87, Column 255: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/role-based-access-control/built-in-roles#network-contributor' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 87, Column 46: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/role-based-access-control/built-in-roles#contributor' will be broken in isolated environments. Replace with a relative link.
  • Line 87, Column 155: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/role-based-access-control/built-in-roles#owner' will be broken in isolated environments. Replace with a relative link.
  • Line 87, Column 255: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/role-based-access-control/built-in-roles#network-contributor' will be broken in isolated environments. Replace with a relative link.

articles/expressroute/expressroute-howto-linkvnet-portal-resource-manager.md

  • Line 106, Column 46: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/role-based-access-control/built-in-roles#contributor' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 106, Column 155: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/role-based-access-control/built-in-roles#owner' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 106, Column 255: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/role-based-access-control/built-in-roles#network-contributor' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 106, Column 46: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/role-based-access-control/built-in-roles#contributor' will be broken in isolated environments. Replace with a relative link.
  • Line 106, Column 155: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/role-based-access-control/built-in-roles#owner' will be broken in isolated environments. Replace with a relative link.
  • Line 106, Column 255: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/role-based-access-control/built-in-roles#network-contributor' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

opbld33 avatar Dec 13 '22 13:12 opbld33

@SebastianClaesson : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Dec 13 '22 13:12 prmerger-automator[bot]

@SebastianClaesson : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Dec 13 '22 13:12 prmerger-automator[bot]

@SebastianClaesson : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Dec 13 '22 13:12 prmerger-automator[bot]

@SebastianClaesson : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Dec 13 '22 13:12 prmerger-automator[bot]

@SebastianClaesson : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Dec 13 '22 13:12 prmerger-automator[bot]

Learn Build status updates of commit c388100:

:bulb: Validation status: suggestions

File Status Preview URL Details
articles/expressroute/expressroute-howto-linkvnet-arm.md :bulb:Suggestion Details
articles/expressroute/expressroute-howto-linkvnet-classic.md :bulb:Suggestion Details
articles/expressroute/expressroute-howto-linkvnet-portal-resource-manager.md :bulb:Suggestion Details

articles/expressroute/expressroute-howto-linkvnet-arm.md

  • Line 92, Column 129: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/role-based-access-control/built-in-roles' will be broken in isolated environments. Replace with a relative link.

articles/expressroute/expressroute-howto-linkvnet-classic.md

  • Line 87, Column 129: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/role-based-access-control/built-in-roles' will be broken in isolated environments. Replace with a relative link.

articles/expressroute/expressroute-howto-linkvnet-portal-resource-manager.md

  • Line 106, Column 129: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/role-based-access-control/built-in-roles' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

opbld31 avatar Dec 13 '22 13:12 opbld31

Learn Build status updates of commit 6326e3b:

:bulb: Validation status: suggestions

File Status Preview URL Details
articles/expressroute/expressroute-howto-linkvnet-arm.md :bulb:Suggestion Details
articles/expressroute/expressroute-howto-linkvnet-classic.md :bulb:Suggestion Details
articles/expressroute/expressroute-howto-linkvnet-portal-resource-manager.md :bulb:Suggestion Details

articles/expressroute/expressroute-howto-linkvnet-arm.md

  • Line 92, Column 129: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/role-based-access-control/built-in-roles' will be broken in isolated environments. Replace with a relative link.

articles/expressroute/expressroute-howto-linkvnet-classic.md

  • Line 87, Column 129: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/role-based-access-control/built-in-roles' will be broken in isolated environments. Replace with a relative link.

articles/expressroute/expressroute-howto-linkvnet-portal-resource-manager.md

  • Line 106, Column 129: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/role-based-access-control/built-in-roles' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

opbld30 avatar Dec 13 '22 13:12 opbld30

@duongau

Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

Court72 avatar Dec 13 '22 17:12 Court72

@Court72 I created another PR: https://github.com/MicrosoftDocs/azure-docs-pr/pull/221321 to replace relative links with absolute links.

@SebastianClaesson Your changes should be live later today. Thank you for your contribution to our documentations.

duongau avatar Dec 13 '22 19:12 duongau

#please-close

duongau avatar Dec 13 '22 19:12 duongau