azure-docs icon indicating copy to clipboard operation
azure-docs copied to clipboard

extend titles with more details

Open BrunoLucasCloud opened this issue 2 years ago • 6 comments

BrunoLucasCloud avatar Dec 13 '22 08:12 BrunoLucasCloud

@BrunoLucasBlog : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Dec 13 '22 08:12 prmerger-automator[bot]

Learn Build status updates of commit 5ea4557:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/azure-functions/functions-bindings-kafka-trigger.md :white_check_mark:Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

opbld31 avatar Dec 13 '22 08:12 opbld31

@ggailey777

Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

Court72 avatar Dec 13 '22 16:12 Court72

Hi, Regarding this document: azure-docs/functions-bindings-kafka-trigger.md at 1973617e34f8976fe94a1b4918d5113de91268b8 · MicrosoftDocs/azure-docs (github.com)https://github.com/MicrosoftDocs/azure-docs/blob/1973617e34f8976fe94a1b4918d5113de91268b8/articles/azure-functions/functions-bindings-kafka-trigger.md

would help if I edit to replace the code references: [cid:14263f0b-6121-471d-ad1a-cd4d6a8b4662]

with the code snippets like in the Azure event hub doco in azure-docs/functions-bindings-event-hubs-trigger.md at 1973617e34f8976fe94a1b4918d5113de91268b8 · MicrosoftDocs/azure-docs (github.com)https://github.com/MicrosoftDocs/azure-docs/blob/1973617e34f8976fe94a1b4918d5113de91268b8/includes/functions-bindings-event-hubs-trigger.md:

[cid:ad7c7d0d-3973-4187-90a3-a25aef64ce37]

Cheers, Bruno


From: Courtney Wales @.> Sent: Tuesday, December 13, 2022 4:53 PM To: MicrosoftDocs/azure-docs @.> Cc: BrunoLucasBlog @.>; Mention @.> Subject: Re: [MicrosoftDocs/azure-docs] extend titles with more details (PR #102638)

@ggailey777https://github.com/ggailey777

Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-teamhttps://github.com/orgs/MicrosoftDocs/teams/public-repo-pr-review-team

— Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/pull/102638#issuecomment-1349054918, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A3UNSATTWUCITRSJEOI5QI3WNCS2BANCNFSM6AAAAAAS443MQE. You are receiving this because you were mentioned.Message ID: @.***>

BrunoLucasCloud avatar Dec 14 '22 10:12 BrunoLucasCloud

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @ggailey777

prmerger-automator[bot] avatar Dec 14 '22 10:12 prmerger-automator[bot]

Invalid command: '#label'. Only Microsoft employees can use this command.

prmerger-automator[bot] avatar Dec 14 '22 10:12 prmerger-automator[bot]

@BrunoLucasCloud this is a good idea. I've shortened your text a bit and I will merge your commit in a separate (internal) PR. Thanks for the good idea here!

ggailey777 avatar Feb 17 '23 17:02 ggailey777

Your commit is now in main in the private repo. You should see the updates this afternoon. Thanks! #please-close

ggailey777 avatar Feb 17 '23 19:02 ggailey777