azure-docs icon indicating copy to clipboard operation
azure-docs copied to clipboard

ADAL to MSAL migration - update apache-spark-sql-connector.md

Open ekote opened this issue 3 years ago • 3 comments

Context: As a way of ensuring that third-party apps / services migrate to MSAL and no new ADAL apps are created, we are looking to work on all our content that endorses / mentions ADAL or endorse products that use the same. We have identified the following doc(s) that need immediate attention.

Changes:

  • get SP credentials via mssparkutils.credentials.getSecret
  • remove adal library
  • use msal to get the token

ekote avatar Oct 21 '22 08:10 ekote

@ekote : Thanks for your contribution! The author(s) have been notified to review your proposed change.

prmerger-automator[bot] avatar Oct 21 '22 08:10 prmerger-automator[bot]

Learn Build status updates of commit b153081:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/synapse-analytics/spark/data-sources/apache-spark-sql-connector.md :white_check_mark:Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

opbld33 avatar Oct 21 '22 08:10 opbld33

@midesa

  • Can you review this PR?
  • IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

Jak-MS avatar Oct 21 '22 15:10 Jak-MS

@ekote : Thanks for your contribution! The author(s) have been notified to review your proposed change. @eskot

prmerger-automator[bot] avatar Oct 25 '22 17:10 prmerger-automator[bot]

Learn Build status updates of commit 9e27622:

:white_check_mark: Validation status: passed

File Status Preview URL Details
articles/synapse-analytics/spark/data-sources/apache-spark-sql-connector.md :white_check_mark:Succeeded

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

opbld30 avatar Oct 25 '22 17:10 opbld30

#sign-off

ekote avatar Oct 25 '22 18:10 ekote

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @eskot

prmerger-automator[bot] avatar Oct 25 '22 18:10 prmerger-automator[bot]

#sign-off

midesa avatar Oct 25 '22 18:10 midesa

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @eskot

prmerger-automator[bot] avatar Oct 25 '22 18:10 prmerger-automator[bot]

#sign-off

ekote avatar Oct 25 '22 19:10 ekote

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @eskot

prmerger-automator[bot] avatar Oct 25 '22 19:10 prmerger-automator[bot]

@midesa

  • Can you review this PR?
  • IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

@Jak-MS - could you please help with the merge? Misha has already approved it.

ekote avatar Oct 25 '22 19:10 ekote