Vorlonjs icon indicating copy to clipboard operation
Vorlonjs copied to clipboard

Console improvements

Open AndrewNelis opened this issue 7 years ago • 1 comments

This pull request attempts to make the console plugin behave like a regular browser console:

  1. We call an alias of eval which does the same thing but evaluates in the global scope. ( https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/eval#Description - see last example ). Otherwise I think if you try to define a variable, it's just defined in the local scope of evalOrderFromDashboard.
  2. We call console.log on the command we're about to execute. This is just to leave a log of it in the console log. Again, to make it look like a normal console.
  3. I removed the isLoggable logic and decided that all responses should be logged.
  4. Removed "unable to execute order" - just show the error in the console!
  5. Don't pass boolean or undefined types to inspect - just pass back as string. Think this should fix #419.

AndrewNelis avatar Nov 21 '18 15:11 AndrewNelis

CLA assistant check
All CLA requirements met.

msftclas avatar Nov 21 '18 15:11 msftclas