Mick Lawitzke

Results 226 comments of Mick Lawitzke

Would love to have this merged! :)

I dont understand where this encode is used exactly and what feature would be missing then. Could you create an module we can import that does not use encoding? Btw....

From my perspective it would be great to have a different import which inits twing without inconv_lite instead of hacking it away when bundling.

Still this is (too) huge :/ Is it possible to refactor twing so each developer can import only the things we actually need? Keyword: tree shaking

@ericmorand > My testing shows than removing iconv-lite decreases the bundle from 1.3MB to 1.0MB with Browserify. Currently it is more than 4MB which is an rediculous amount of code...

Maybe do 9999 days instead? Btw. I get the error: > Error: self signed certificate

Or maybe `Model` should be kept in `nestjs-dynamoose` if it is/behaves differently but then it should extend interfaces from `dynamoose` if possible. The best would be if one does not...

Could you explain what you mean by broken? > I will review the interfaces and match the new v2 api as much as possible Thanks for your efforts! Even tho...

In my opinion it should never be necessary to use `// @ts-ignore`. Within a lot of projects it is also forbidden to use ts-ignore by eslint rules. The problem is...

Using `deviceIndexes: true` does not change anything for me. The string `Mozilla/5.0 (Linux; Android 5.0; NX505J Build/KVT49L) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.78 Mobile Safari/537.36` always is about 84-86ms