Kronecker.jl icon indicating copy to clipboard operation
Kronecker.jl copied to clipboard

Factorisations

Open willtebbutt opened this issue 6 years ago • 6 comments
trafficstars

Would be very helpful to have efficient implementations for cholesky, eigen, etc for Kronecker-product matrices (I believe these have efficient representations).

(Nice talk btw)

willtebbutt avatar Jul 23 '19 15:07 willtebbutt

A function for cholesky and related support is now added in a new module. CholeskyKronecker is part of my type system, but should behave similarly to Cholesky of the LinearAlgebra module.

Work in progress!

MichielStock avatar Jul 26 '19 23:07 MichielStock

Update: eigen was resolved by #16. Just leaves implementing the cholesky in a similar manner.

willtebbutt avatar Aug 03 '19 20:08 willtebbutt

Hmmm, was looking to do cholesky the same way, but this seems to be more challenging:

https://github.com/JuliaLang/julia/blob/36c59c144122dbf09fc0e1f0f1e9defbbd2f254d/stdlib/LinearAlgebra/src/cholesky.jl#L72-L81

The current implementation has its own type within Kronecker.jl type system. I don't see how elso to do this?

MichielStock avatar Sep 05 '19 12:09 MichielStock

I had a working prototype a while ago i think. Will dig it out and try to finish it off + make a PR in the next few days.

willtebbutt avatar Sep 05 '19 12:09 willtebbutt

If you post it, I can do it?

MichielStock avatar Sep 05 '19 12:09 MichielStock

Required a bit of work to get anything off the ground, so make #44 .

willtebbutt avatar Sep 06 '19 15:09 willtebbutt