typegraphql-prisma icon indicating copy to clipboard operation
typegraphql-prisma copied to clipboard

add support for Prisma 6

Open FezVrasta opened this issue 1 year ago • 6 comments

Fixes #475

FezVrasta avatar Dec 09 '24 13:12 FezVrasta

Please, merge this. Will help me a lot! Thz!

lucasrivoiro avatar Dec 19 '24 12:12 lucasrivoiro

Bump

gabrielbryk avatar Jan 03 '25 03:01 gabrielbryk

When i launch tests with [email protected] i get this results:

Test Suites: 5 failed, 15 passed, 20 total
Tests:       29 failed, 135 passed, 164 total
Snapshots:   39 failed, 20 obsolete, 461 passed, 500 total
Time:        63.238 s

I would like to have this merge too, but i don't think that's possible as is.

rlecellier avatar Jan 09 '25 14:01 rlecellier

@rlecellier You're right, upgrading to new a Prisma version, especially major release, is not as simple as bumping dependency.

Tests need to be passing green. Most of them are snapshot-based. So the one who upgrades (maintainer/contributor) has to examine the reported snapshots differences and decides if they are matching expectation (like when Prisma changed to findOrThrow API) and only then update the snapshots. Sometimes some changes around DMMF parsing are required to properly translate it into the format used by the class generator, so we keep emitting fields and types properly, are not missing new methods, etc.

If someone is willing to spend more time on updating this tool to new Prisma release, I'm happy to colaborate, answer question or guide how to achieve something in the code.

MichalLytek avatar Jan 16 '25 11:01 MichalLytek

FYI I have been using this patch on a production app for months with zero issues.

FezVrasta avatar Jan 16 '25 15:01 FezVrasta

Can anyone merge this PR please? @MichalLytek 🙏

marticrespi avatar Mar 18 '25 10:03 marticrespi