type-graphql icon indicating copy to clipboard operation
type-graphql copied to clipboard

GitHub sponsors missing in the members sections

Open itpropro opened this issue 4 years ago • 5 comments

Currently only OpenCollective sponsors, not GitHub sponsors (https://github.com/TypeGraphQL) are updated in the README. As there are more sponsors on GitHub (at elast for member tier) and there is not much to see in regards to new code (as I understood, you currently develop the next version privately @MichalLytek), I think it would be a nice touch to have all the sponsors listed in the same place.

itpropro avatar Mar 06 '22 16:03 itpropro

You're right, I was thinking about it but forgot at some time when some contributors on GitHub sponsors appeared.

Do you know if I can somehow automatically display the financial contributors via a generated image, like open collective is able to do?

MichalLytek avatar Mar 06 '22 16:03 MichalLytek

There is a great toolkit for generating sponsor images by @antfu, which I have seen some people use (https://github.com/antfu/sponsorkit). I hope that helps as I don't have any experience in managing sponsors, only with sponsoring :)

itpropro avatar Mar 06 '22 16:03 itpropro

There is a few other tools like: https://github.com/JamesIves/github-sponsors-readme-action

I think I would gratefully accept PR that adds the github sponsors images to the readme and website section. Image generator script would be the best to integrate in the worfklows 😉

MichalLytek avatar Jun 07 '22 11:06 MichalLytek

I think it would be best if you as repository and org owner decide which format and highlighting of different levels you prefer for your sponsors, implement that and integrate it into some CI pipeline for all of your projects.

itpropro avatar Jun 25 '22 12:06 itpropro

@MichalLytek if no one is working on this, I think it would be a something I could play with on the weekend. #myweekendsarefun

jahead avatar Sep 05 '22 02:09 jahead

To myself: integrate with this tool: https://github.com/antfu/sponsorkit

MichalLytek avatar Feb 24 '23 10:02 MichalLytek

Working on PR #1400

carlocorradini avatar Feb 24 '23 14:02 carlocorradini

See commit 053236335cc0e9e795925554ae99d1e43fae237d

carlocorradini avatar Feb 24 '23 15:02 carlocorradini

@carlocorradini can we extract this into a separate PR? I would like to play with this in a quicker manner than the rest of this 1400 PR 😉

MichalLytek avatar Feb 24 '23 15:02 MichalLytek

@MichalLytek Copy the changes made in another PR and revert them to avoid conflicts.

I'm away from my computer now :/

carlocorradini avatar Feb 24 '23 15:02 carlocorradini

@MichalLytek I'm thinking about two options:

  1. Single image with all sponsors
  2. Multiple images (similar to what we have now) under the corresponding MD title/subtitle

carlocorradini avatar Feb 25 '23 11:02 carlocorradini

@carlocorradini We need multiple images like we have now. We have different sponsor tiers, we can't have all together 😛

Also sponsors should be clickable with link to ther website. So maybe we should use this tool only to generate image for gihub backers?

MichalLytek avatar Feb 27 '23 08:02 MichalLytek

@MichalLytek It's possible if you check the example on the site. Unfortunately I can't try to generate the images due to che API keys required :/

carlocorradini avatar Feb 27 '23 09:02 carlocorradini

@itpropro Please check the changes in sponsors section in readme and website 😉

MichalLytek avatar Mar 06 '23 14:03 MichalLytek