Zhanghao Wu
Zhanghao Wu
Thanks @sieu-n for reporting this! Could you create a new issue for this with the version of SkyPilot you are using? Also, it would worth noticing that there is a...
Important problem: Seems we have a bug with the `tests/backward_comaptibility_tests.sh`, that we did not capture the following backward compatibility issue: ``` git checkout master sky launch -c min git checkout...
This PR should go after #1513 with a `sky status -r` to make sure the switching between different account will not cause resource leakage when `sky status -r` is called.
Tested (24e22c9): - [x] `AWS_PROFILE=admin-user sky launch -c sso -t t3.micro -i 1` - [x] `AWS_PROFILE=admin-user sky launch -c sso-down -t t3.micro -i 1 --down` - [x] `sky status -r`...
Tested (75b3424): - [x] `AWS_PROFILE=admin-user sky launch -c sso -t t3.micro -i 1` - [x] `AWS_PROFILE=admin-user sky launch -c sso-down -t t3.micro -i 1 --down` - [x] `sky status -r`...
Testing the smoke tests again with [55468c7](https://github.com/skypilot-org/skypilot/pull/1513/commits/55468c74eda72d8167374ec3ddb9928461aaee36) - [x] `tests/run_smoke_tests.sh` - [x] `tests/run_smoke_tests.sh` with a spot controller on GCP. - [x] `tests/backward_compatiblity_tests.sh`
We now check the identity only when the code modifies the cluster or has some cloud API operations. Including the following places: 1. Before provisioning on an existing cluster; 2....
> `dbg` from the old account is unexpectedly removed from the cluster table. Confirmed that the console of the non-SSO account still shows it as running. As discussed offline, this...
Tested (cb40ca6): - [x] `tests/backward_compatibility_tests.sh` (with the `sqlite3 ~/.sky/state.db 'ALTER TABLE clusters DROP owner;'` after each `conda activate sky-back-compat-master`) - [x] `sky launch -c nonsso -t t3.micro; AWS_PROFILE=admin-user sky down...
> Should we edit the PR description for upgrade instructions? Mainly asking multi-identity users to run sky status -r; users who use a single identity in each cloud are not...