Michael R Fairhurst

Error getting dart template validation when given special chars

1

``` template: '\v' ``` causes a crash: ``` NoSuchMethodError: The getter 'start' was called on null. Receiver: null Tried calling: start #0 Object._noSuchMethod (dart:core-patch/object_patch.dart:44) #1 Object.noSuchMethod (dart:core-patch/object_patch.dart:47) #2 DartTemplateResolver._reportErrorForSpan (package:angular_analyzer_plugin/src/resolver.dart:99)...

Variables can be overwritten with #thissyntax, and in ngFor, maybe a few other places...

This selector doesn't report any errors: `foo+`, while this one: `foo+bar` does. I think its because the mini tokenizer in the selector reports `+` as an error only when it...

Small issue we could warn about: binding to content attributes when there's content already

3

See this SO post: http://stackoverflow.com/questions/38992712/angular2-dart-component-template-not-loading basically `z` should report a conflict between `z` and `y`. same for `innerHtml`, which I think is used more often than `innerText`. And maybe a...

In the following code: ``` @Component(...) class Foo { @Output final onSomething = new EventEmitter(); ... } ``` the type of `onSomething` is `dynamic`, not `EventEmitter`. I have opened a...

Can put ngModel on a li?

2

This passes our analyzer, and, almost certainly shouldn't: ``` ... ``` Seems like anything can have `ngModel`. As a short term solution, we could make a whitelist (or even a...

Warn users about values initialized in ngOnInit and bound in template

2

See here: http://stackoverflow.com/questions/39770978/dart-angular2-null-error-when-rendering-an-object-in-template/39771002#39771002 Would probably be difficult to catch, and maybe belongs in linter, but this would be a nice thing to catch.

Catch doubly defined inputs & outputs

4

For example ``` ``` and ``` ``` and even ``` ``` All should be errors. Probably best to highlight both as errors though we could highlight just the second one

Looks like this is an all-or-nothing selector rule which matches a Text node in the DOM. What do directives do that we care about after being bound to a TextInfo...

Catch binding to native image properties natively which doesn't work

2

Very easy to accidentally write `` but that won't work, should be (I think...) `` Note that this _can_ be valid. So it should be a lint error, which we...