Michael Orlov

Results 271 comments of Michael Orlov

@clalancette, I agree with @mjcarroll and yes I would like to keep it in rosbag2 to be able to backport it to the iron branch. And will get rid of...

> @MichaelOrlov would you be willing to make the patch to add the helpers to `rclcpp`? @emersonknapp Yes. I can try to make the changes in `rcpcpp` layer but a...

- Update: Removed dependencies from https://github.com/ros2/rosbag2/pull/1301 and rebased on top of the latest Rolling to be able to move forward with this PR and easily backport it to the Iron...

Gist: https://gist.githubusercontent.com/MichaelOrlov/55adb4c4d5dac5435adace5c095d45b2/raw/09cc03757951ddc3c5ec8885a4d766a84f26207f/ros2.repos BUILD args: --packages-above-and-dependencies rosbag2_py rosbag2_test_common ros2bag rosbag2_transport rosbag2_tests TEST args: --packages-above rosbag2_py rosbag2_test_common ros2bag rosbag2_transport rosbag2_tests ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12152 * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=18847)](http://ci.ros2.org/job/ci_linux/18847/)...

Returning back to draft due to some unexpected test failures on CI which are not reproduced locally and need to be investigated.

Re-run CI after rebase and adjusting expectations in flaky ros2bag record tests ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12197 * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=18901)](http://ci.ros2.org/job/ci_linux/18901/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=13436)](http://ci.ros2.org/job/ci_linux-aarch64/13436/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=19658)](http://ci.ros2.org/job/ci_windows/19658/)

It seems that CI failure on windows in [rosbag2_tests.TestPlayEndToEnd/PlayEndToEndTestFixture.](https://ci.ros2.org/job/ci_windows/19658/testReport/junit/rosbag2_tests/TestPlayEndToEnd_PlayEndToEndTestFixture/play_end_to_end_exits_gracefully_on_sigint_0___sqlite3_______________________/) relates to the way how we are running tests on Windows CI. It fails with the error messages ``` C:\ci\ws\install\include\rosbag2_test_common\rosbag2_test_common\process_execution_helpers_windows.hpp(177): error:...

@nuclearsandwich If I am not mistaken I recall that we had a plan to move to the `Windows Server 2019` on our Windows CI builds. Could you please comment about...

Re-running CI after rebase since on today's ROS2 weekly synch meeting was mentioned that buildfarm CI already migrated to the Windows Server 2020. Will see if the issue still persists....

Re-run Windows CI job after adding `ctrl_c_event_can_be_send_and_received` sanity test * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=19807)](http://ci.ros2.org/job/ci_windows/19807/)