Michael Orlov

Results 271 comments of Michael Orlov

i.e. when specified just folder name `ros2 bag record -a -d 60 -o my_bag -s mcap` the file naming inside `my_bag` folder will be `my_bag_0.mcap`, `my_bag_1.mcap`, `my_bag_2.mcap`. Anyway we store...

@james-rms @emersonknapp Can we close this issue as resolved in #1209 ?

What behavior if specify folder with .db3 file and `metadata.yaml` file? for `ros2 bag play` command? For the same recorded .db3 file. Also does this issue still reproduces for ROS2...

Preliminary analysis: Exception with rrror message "cannot get file size: The file pointer cannot be set on the specified device or file." coming from https://github.com/ros2/rosbag2/blob/197b09481a167d7fe9414c23945a778288f44a62/rosbag2_storage_default_plugins/src/rosbag2_storage_default_plugins/sqlite/sqlite_storage.cpp#L204-L209 Which is called from https://github.com/ros2/rosbag2/blob/197b09481a167d7fe9414c23945a778288f44a62/rosbag2_storage_default_plugins/src/rosbag2_storage_default_plugins/sqlite/sqlite_storage.cpp#L357...

It seems `relative_path_` should have a valid value since we checking it for existence and even opening database file in `open(..)` method https://github.com/ros2/rosbag2/blob/197b09481a167d7fe9414c23945a778288f44a62/rosbag2_storage_default_plugins/src/rosbag2_storage_default_plugins/sqlite/sqlite_storage.cpp#L89-L99 We calling `storage_->get_metadata();` when storage already has...

Gist: https://gist.githubusercontent.com/MichaelOrlov/2caa5eb5c736bf13186621013824cdbd/raw/2ecca7eef32ec2e5a26f9c80d0b619a6277d600c/ros2.repos BUILD args: --packages-above-and-dependencies bag_recorder_nodes_py TEST args: --packages-above bag_recorder_nodes_py ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/10779 * Linux [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux&build=17264)](http://ci.ros2.org/job/ci_linux/17264/) * Linux-aarch64 [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_linux-aarch64&build=11803)](http://ci.ros2.org/job/ci_linux-aarch64/11803/) * Windows [![Build Status](http://ci.ros2.org/buildStatus/icon?job=ci_windows&build=17744)](http://ci.ros2.org/job/ci_windows/17744/)

Closing this issue since the are nothing to fix in rosbag2. This is underlying issue in `rcpputils` package. Feel free to re-open if disagree.

@gbiggs Could you please rebase this PR to the latest rolling branch. It seems this PR branched from very outdated version and CI fails due to changes in API.

@gbiggs Honestly I more like folder names as it was proposed in #1068 i.e. `rosbag2_examples` instead `rosbag2_samples` "Samples" has a bit different associations in regards to the rosbag2. It's more...

@DLu It seems @gbiggs is busy with another tasks and roles. I think it would be reasonable to create a new PR with relative changes and proposals. The help with...