git-bug icon indicating copy to clipboard operation
git-bug copied to clipboard

Error when querying bugs with 1+ parameters

Open danisztls opened this issue 1 year ago • 3 comments

When running the following command from the README:

git bug ls "status:open sort:edit"

It returns Error: unknown qualifier "status:open sort"

Though this works fine:

git bug ls "status:open" "sort:edit"

danisztls avatar Mar 05 '23 23:03 danisztls

It also works without any quotes at all - I'm a bit surprised that it didn't consider the whole enclosed string as a text query. The next example in the README definitely requires the quote (in Bash on Linux) to escape the space:

git bug ls "foo bar" baz

Clearly it would be possible to fix the README but making the argument parsing more robust would be more user-friendly. I'll take a look at whether the command-line parsing code in Cobra is platform dependent. I'm also wondering if there's a way to test this for all OSes and shells we support.

smoyer64 avatar Mar 06 '23 10:03 smoyer64

I'm also wondering if there's a way to test this for all OSes and shells we support.

Can use a GH workflow for that and compare command outputs with expected values.

danisztls avatar Mar 06 '23 11:03 danisztls

Yes ... there are a ton of tests running via GHA on Windows, Mac OSX and Linux in 'git-bug'. What I meant is that we may not be able to test with every permutation of shell and OS, and that during testing (at least using go test), we can't control how the shell might process the arguments before it passes them to Go.

smoyer64 avatar Mar 06 '23 22:03 smoyer64

This bot triages untriaged issues and PRs according to the following rules:

  • After 90 days of inactivity, the lifecycle/stale label is applied
  • After 30 days of inactivity since lifecycle/stale was applied, the issue is closed

To remove the stale status, you can:

  • Remove the lifecycle/stale label
  • Comment on this issue

github-actions[bot] avatar Jul 23 '24 03:07 github-actions[bot]